darcs

Issue 100 corrupted pristine cache

Title corrupted pristine cache
Priority bug Status duplicate
Milestone Resolved in
Superseder More robust pristine cache
View: 230
Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy
Assigned To
Topics

Created on 2006-01-17.15:59:13 by kowey, last changed 2009-08-27.13:51:25 by admin.

Files
File name Uploaded Type Edit Remove
TSNLP-darcs-corruption.tgz kowey, 2006-01-17.15:59:12 application/x-gzip
Messages
msg381 (view) Author: kowey Date: 2006-01-17.15:59:11
The repository in this tarball was only ever used as a central push depot,
nobody ever added anything to this by any other means than darcs push.  Yet, if
you do a darcs whatsnew, you see some changes...
Attachments
msg382 (view) Author: kowey Date: 2006-01-17.16:33:58
I'll also add that darcs check on the corrupted repository shows the inverse of
the darcs whatsnew
msg387 (view) Author: droundy Date: 2006-01-18.11:14:31
On Tue, Jan 17, 2006 at 04:33:59PM +0000, Eric Kow wrote:
> I'll also add that darcs check on the corrupted repository shows the
> inverse of the darcs whatsnew

Indeed, it looks here like darcs failed in the middle of an operation,
leaving the pristine cache in a corrupt state.  The good news is that the
pristine cache in a push-only repo is only ever used as a check, so this
couldn't cause corruption elsewhere (unless the push-only repo was local,
in which case a local get would copy the corrupt pristine cache).

I'm afraid it looks like it would be very hard to track down the origin of
this corruption without knowing when it failed.  It would be nice to
introduce a secondary lock to darcs which would indicate a corrupt
repository.  I imagine a file that we create when we start modifying the
pristine cache and delete when the operation is done.
-- 
David Roundy
http://www.darcs.net
msg390 (view) Author: kowey Date: 2006-01-18.16:53:34
That's a relief... but I might mention also that we only noticed this
'corruption' when we tried to do a darcs push and it wrongly told us that there
was a conflict.  But from what you're saying, once we darcs repair and move on,
everything should be fine?
msg393 (view) Author: droundy Date: 2006-01-19.13:11:56
On Wed, Jan 18, 2006 at 04:53:35PM +0000, Eric Kow wrote:
> That's a relief... but I might mention also that we only noticed this
> 'corruption' when we tried to do a darcs push and it wrongly told us that
> there was a conflict.  But from what you're saying, once we darcs repair
> and move on, everything should be fine?

Yes, that's precisely it.  Darcs wrongly told you there was a conflict
because the consistency check was wrong, but that was all that was wrong.
-- 
David Roundy
http://www.darcs.net
History
Date User Action Args
2006-01-17 15:59:13koweycreate
2006-01-17 16:33:58koweysetstatus: unread -> unknown
nosy: droundy, tommy, kowey
messages: + msg382
2006-01-18 11:14:32droundysetnosy: droundy, tommy, kowey
messages: + msg387
2006-01-18 16:53:35koweysetnosy: droundy, tommy, kowey
messages: + msg390
2006-01-19 13:11:57droundysetnosy: droundy, tommy, kowey
messages: + msg393
2006-04-07 22:56:33jchsetnosy: droundy, tommy, kowey
title: whatsnew shows changes in a repo only used for pushing -> corrupted pristine cache
2007-08-09 12:40:37koweysetstatus: unknown -> duplicate
nosy: + beschmi
superseder: + More robust pristine cache
2009-08-06 17:39:56adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, thorkilnaur, - droundy
2009-08-06 20:36:58adminsetnosy: - beschmi
2009-08-10 21:42:27adminsetnosy: - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:53:33adminsetnosy: + darcs-devel, - simon
2009-08-27 13:51:25adminsetnosy: tommy, kowey, darcs-devel, thorkilnaur, dmitry.kurochkin