darcs

Issue 1010 log failures applying to working dir as patch; and keep warning the user about them

Title log failures applying to working dir as patch; and keep warning the user about them
Priority feature Status given-up
Milestone Resolved in
Superseder Nosy List claus.reinke, darcs-devel, dmitry.kurochkin, kowey, mornfall, thorkilnaur
Assigned To
Topics

Created on 2008-08-17.21:10:42 by kowey, last changed 2017-07-30.23:09:24 by gh.

Messages
msg5567 (view) Author: kowey Date: 2008-08-17.21:10:39
Claus suggests a feature for whenever we capture a failure to apply a patch to
the working directory via tolerant IO.  Basically, we should note what happened
and keep warning the user about it (that is, on every darcs invocation) until
s/he takes some action to suppress the warning.  For example, it could tell the
user to delete the file _darcs/warnings or something.

From Claus Reinke:

> Having skimmed over the ticket relating to "moving on", that
> seems to have been a shortcut/workaround, rather than a feature
> (#434, where the suggested fix was to make darcs actions atomic:
> either they succeed or not, but nothing in between).

> In particular, darcs should be able to recognize that it has taken
> that shortcut, which means recording a flag "pristine and working
> out of sync because <warnings here>", and repeating the warnings
> for every darcs command until the user addresses the issues and
> resets the flag. Currently, darcs doesn't distinguish between its
> own messing up and the user editing working, which isn't good,
> especially if there are real unrecorded user changes in working.
msg5580 (view) Author: mornfall Date: 2008-08-18.15:57:33
I think it would be actually much better to write the failed hunks to
_darcs/patches/failed (akin to pending) and warn the user. darcs repair --failed-
do that after fixing the permission/whatever problem happened).

Thoughts?
msg5582 (view) Author: kowey Date: 2008-08-18.16:27:44
Sounds like a great idea, saving the patch itself instead of just a warning.  I
think Jason has had the same idea (great minds, etc)...

It might take a little work percolating this stuff up from the IO level (would
we do away with tolerant IO, for example?).  

Not very urgent, but something nice to have.
History
Date User Action Args
2008-08-17 21:10:42koweycreate
2008-08-18 15:57:35mornfallsetstatus: unread -> unknown
nosy: + mornfall
messages: + msg5580
2008-08-18 16:27:46koweysetstatus: unknown -> needs-reproduction
nosy: beschmi, kowey, dagit, claus.reinke, mornfall
messages: + msg5582
2009-08-06 21:11:24adminsetnosy: + simon, dmitry.kurochkin, thorkilnaur, - beschmi
2009-08-10 23:42:50adminsetnosy: - dagit
2009-08-25 18:14:05adminsetnosy: + darcs-devel, - simon
2009-08-27 14:03:04adminsetnosy: kowey, darcs-devel, thorkilnaur, claus.reinke, dmitry.kurochkin, mornfall
2009-09-04 17:08:18koweysetstatus: needs-reproduction -> needs-implementation
nosy: kowey, darcs-devel, thorkilnaur, claus.reinke, dmitry.kurochkin, mornfall
title: log errors apply to working dir and keep warning the user about them -> log failures applying to working dir as patch; and keep warning the user about them
2009-09-05 09:37:52koweylinkissue826 superseder
2017-07-30 23:09:24ghsetstatus: needs-implementation -> given-up