darcs

Issue 1024 darcs2 client regression in get

Title darcs2 client regression in get
Priority bug Status resolved
Milestone Resolved in
Superseder rmfile patch created without the actual content removal (tailor)
View: 693
Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur
Assigned To
Topics

Created on 2008-08-21.06:53:02 by dagit, last changed 2009-08-27.14:25:31 by admin.

Messages
msg5620 (view) Author: dagit Date: 2008-08-21.06:52:59
darcs get http://src.seereason.com/HAppS/HAppS-IxSet.broken/

Unapplicable patch:                                                     
Mon Oct  9 02:31:52 PDT 2006  Einar Karttunen <einar@vo.com>
  * Remove S3 stuff that was never enabled from the repo

darcs failed:  Cannot remove non-empty file ./src/HAppS/Protocols/S3.hs


A darcs get --hashed works, but in either case darcs check reports the same
error.  The user that reported this said that darcs 1.0.9 didn't give this error
on get.

A darcs repair seems to fix the problem (even check no longer complains).

Also, darcs changes ./src/HAppS/Protocols/S3.hs lists all the patches that touch
this file while
darcs changes -i ./src/HAppS/Protocols/S3.hs lists only one patch.

I believe this later behavior is a different bug that can/will be fixed when
changes is updated to be type safe.  The current changes implementation filters
patches out of a sequence and then commutes the results, which is not right.
msg5621 (view) Author: dagit Date: 2008-08-21.06:54:06
This also happens when getting the official HAppS-IxSet repo:
darcs get http://happs.org/repos/HAppS-IxSet
msg5624 (view) Author: daveroundy Date: 2008-08-21.12:23:33
This corruption is caused by a known bug in darcs 1.  It can be fixed
with darcs repair in a recent darcs, as you've observed.

David

On Thu, Aug 21, 2008 at 2:53 AM, Jason Dagit <bugs@darcs.net> wrote:
> darcs get http://src.seereason.com/HAppS/HAppS-IxSet.broken/
>
> Unapplicable patch:
> Mon Oct  9 02:31:52 PDT 2006  Einar Karttunen <einar@vo.com>
>  * Remove S3 stuff that was never enabled from the repo
>
> darcs failed:  Cannot remove non-empty file ./src/HAppS/Protocols/S3.hs
>
>
> A darcs get --hashed works, but in either case darcs check reports the same
> error.  The user that reported this said that darcs 1.0.9 didn't give this error
> on get.
>
> A darcs repair seems to fix the problem (even check no longer complains).
>
> Also, darcs changes ./src/HAppS/Protocols/S3.hs lists all the patches that touch
> this file while
> darcs changes -i ./src/HAppS/Protocols/S3.hs lists only one patch.
>
> I believe this later behavior is a different bug that can/will be fixed when
> changes is updated to be type safe.  The current changes implementation filters
> patches out of a sequence and then commutes the results, which is not right.
msg5625 (view) Author: kowey Date: 2008-08-21.16:37:13
Retitling to focus on the remaining bug re: changes -i
msg8211 (view) Author: kowey Date: 2009-08-17.17:26:05
Going back to original title and resolving.
I've moved the changes -i problem to its own bug: issue1531
History
Date User Action Args
2008-08-21 06:53:02dagitcreate
2008-08-21 06:54:08dagitsetstatus: unread -> unknown
nosy: beschmi, kowey, dagit
messages: + msg5621
2008-08-21 12:23:35daveroundysetnosy: + daveroundy
messages: + msg5624
2008-08-21 16:37:15koweysetnosy: beschmi, kowey, dagit, daveroundy
superseder: + rmfile patch created without the actual content removal (tailor)
messages: + msg5625
title: darcs2 client regression in get -> changes -i does not list all patches that touch a file
2008-09-28 20:50:06adminsetnosy: + droundy, simon, thorkilnaur, - daveroundy
2009-08-06 18:00:50adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, tommy, - droundy
2009-08-06 21:11:55adminsetnosy: - beschmi
2009-08-10 21:42:34adminsetnosy: - tommy, markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:43:28adminsetnosy: - dagit
2009-08-17 17:26:09koweysetstatus: unknown -> resolved
nosy: kowey, simon, thorkilnaur, dmitry.kurochkin
messages: + msg8211
title: changes -i does not list all patches that touch a file -> darcs2 client regression in get
2009-08-25 17:29:37adminsetnosy: + darcs-devel, - simon
2009-08-27 14:25:31adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin