More dards2 output on Windows

Notice the line in red is truncated.  Is there any need to truncate the message?  I did have a moment when I wondered what this "b" package was...

Simon

Identifying repository simonpj@darcs.haskell.org:/home/darcs/packages/base
scp: /home/darcs/packages/base/_darcs/format: No such file or directory
Identifying repository simonpj@darcs.haskell.org:/home/darcs/packages/base
scp: /home/darcs/packages/base/_darcs/prefs/sources: No such file or directory
Reading inventory of repository simonpj@darcs.haskell.org:/home/darcs/packages/b
scp: /home/darcs/packages/base/_darcs/prefs/motd: No such file or directory
Reading inventory of repository c:/simonpj/darcs/validate-HEAD/libraries/base
Pulling from "simonpj@darcs.haskell.org:/home/darcs/packages/base"...

Attachments

• unnamed

Simon's red line is:
Reading inventory of repository simonpj@darcs.haskell.org:/home/darcs/packages/b

By the way Simon, I don't see the red lines, not on gmail anyway, and certainly
not on the bugtracker!

If anybody wants to look into this, you'd probably want to work out why we
truncate the messages.

On Fri, Aug 22, 2008 at 02:08:06AM +0000, Simon Peyton-Jones wrote:
> More darcs2 output on Windows.  Notice the line in red is truncated.
> Is there any need to truncate the message?  I did have a moment when
> I wondered what this "b" package was...
>
> Identifying repository simonpj@darcs.haskell.org:/home/darcs/packages/base
> scp: /home/darcs/packages/base/_darcs/format: No such file or directory
> Identifying repository simonpj@darcs.haskell.org:/home/darcs/packages/base
> scp: /home/darcs/packages/base/_darcs/prefs/sources: No such file or directory
> Reading inventory of repository simonpj@darcs.haskell.org:/home/darcs/packages/b

This is the only occurrence of "Reading inventory of repository", in
src/Darcs/Repository/DarcsRepo.lhs.  I don't see where the truncation
is happening.  toPath just returns the string part of the object, and
ioAbsoluteOrRemote is just converting the string to a remote path
(because isdir "simon...base" fails).

  read_repo :: RepoPatch p => [DarcsFlag] -> String -> IO (SealedPatchSet p)
  read_repo opts d = do
    realdir <- toPath `fmap` ioAbsoluteOrRemote d
    let k = "Reading inventory of repository "++d
    beginTedious k
    read_repo_private k opts realdir "inventory" `catch`
                          (\e -> do hPutStrLn stderr ("Invalid repository:  " ++ realdir)
                                    ioError e)

Can anyone reproduce this with a recent version of darcs (i.e. 2.2)?
The report doesn't contain instructions on how to generate this error,
and I don't know how.

Is it possible that the output was simply truncated by the terminal
emulator in which it was running, or something along those lines?

On Wed, May 13, 2009 at 04:41:46 -0000, Trent Buck wrote:
> This is the only occurrence of "Reading inventory of repository", in
> src/Darcs/Repository/DarcsRepo.lhs.  I don't see where the truncation
> is happening.  toPath just returns the string part of the object, and
> ioAbsoluteOrRemote is just converting the string to a remote path
> 
>   read_repo :: RepoPatch p => [DarcsFlag] -> String -> IO (SealedPatchSet p)
>   read_repo opts d = do
>     realdir <- toPath `fmap` ioAbsoluteOrRemote d
>     let k = "Reading inventory of repository "++d
>     beginTedious k

Furthermore, this beginTedious function does does an hPutStrLn stderr
of the string via debugMessage.

What we could do maybe is make a small demonstrator that prints some
very long strings with the progress reporting mechanism or maybe
just debugMessage.

We still need somebody to confirm that this truncation happens.  Perhaps
Salvatore?  It shouldn't take a very long time...

I cannot reproduce this on my mac: very long pathnames are shown in full
by --debug-verbose. Also, read_repo no longer exists in the source code,
seemingly replaced by readOldRepo in Old.hs.