darcs

Issue 1045 Leading / stripped from local repository

Title Leading / stripped from local repository
Priority urgent Status resolved
Milestone 2.1.x Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kili, kowey, thorkilnaur
Assigned To
Topics IncludesExampleOrTest, Regression

Created on 2008-08-29.23:37:41 by kili, last changed 2010-06-15.21:48:18 by admin.

Files
File name Uploaded Type Edit Remove
ms.sh kili, 2008-09-06.14:10:45 application/x-shellscript
Messages
msg5802 (view) Author: kili Date: 2008-08-29.23:37:39
As posted on darcs-users@, there's a regression since darcs-2.0.2 when pulling 
from a local (filesystem) repository where the first component of the source 
repository's path differs from the first component of the the target 
repository's path, i.e.:

$ mkdir /var/tmp/foo
$ cd /var/tmp/foo
$ darcs init
$ cd /tmp
$ darcs get /var/tmp/foo
Finished getting.
$ cd foo
$ darcs pull
darcs failed:  Not a repository: var/tmp/foo (var/tmp/foo/_darcs/inventory:
+openBinaryFile: does not exist (No such file or directory))


I didn't yet find the code to blame, but it might be in the vicinity of 
FileName.lhs or any module that's using it (which is pretty much anything).
msg5808 (view) Author: kowey Date: 2008-08-30.07:39:02
Hi Dmitry,  May I interest you in this one?  I think it may be related to the
issue950 fixes or the subsequent cleanups.  Sorry about this!  Definitely a
documentation or lack-of-tests problem on my part.
msg5826 (view) Author: droundy Date: 2008-08-30.17:41:57
I believe this is now fixed.  Thanks for the report!

David
msg5827 (view) Author: droundy Date: 2008-08-30.17:46:00
I take that back.  I fixed it before lunch, but now I see that I didn't record
before pushing... the fix will arrive soon!  :)

David
msg5922 (view) Author: kili Date: 2008-09-06.14:10:45
David, did you forget to record and push this? It still doesn't work here.

Attached is a little shell script that does the same stuff with repodirs /a 
and /b (must be run as root, and it removes /a and /b after the test, so be 
careful).
Attachments
msg5927 (view) Author: kowey Date: 2008-09-07.11:54:26
I can confirm that Matthias's test fails with
darcs failed:  Not a repository: a (a/_darcs/inventory: openBinaryFile: does not
exist (No such file or directory))

Dmitry or David, comments?

P.S. I tried to make this more general by prepending PWD, but then the test
passed :-/
msg5930 (view) Author: dmitry.kurochkin Date: 2008-09-07.21:52:17
I am not working on this one. At least until David comments.

Regards,
  Dmitry
msg5937 (view) Author: droundy Date: 2008-09-08.13:56:47
On Sun, Sep 07, 2008 at 09:52:19PM -0000, dmitry.kurochkin wrote:
> I am not working on this one. At least until David comments.

I'm not sure what's causing this, and don't have the time to look at
it any time soon.

David
msg5960 (view) Author: kowey Date: 2008-09-09.07:45:41
Ok, I need a volunteer to look into this.  Note the test case.   You'd probably
want to poke at the repopath module.  I'm promoting this to urgent just because
the potential 2.0.3 release is blocking on it.
msg5973 (view) Author: dmitry.kurochkin Date: 2008-09-10.11:19:27
Works for me with the latest darcs unstable. Looks like this was fixed by recent
patches from David.

Regards,
  Dmitry
msg5974 (view) Author: kowey Date: 2008-09-10.13:01:09
Resolving in unstable then.  Thanks!
msg5978 (view) Author: kili Date: 2008-09-10.21:00:28
On Wed, Sep 10, 2008 at 11:19:29AM -0000, dmitry.kurochkin wrote:
> Works for me with the latest darcs unstable. Looks like this was
> fixed by recent patches from David.

Yep, I can confirm that. Thanks.
History
Date User Action Args
2008-08-29 23:37:41kilicreate
2008-08-30 07:39:09koweysettopic: + Regression, Target-2.1
nosy: + dmitry.kurochkin
status: unread -> unknown
messages: + msg5808
assignedto: dmitry.kurochkin
2008-08-30 17:41:59droundysetnosy: + droundy
messages: + msg5826
2008-08-30 17:46:02droundysetnosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5827
2008-08-31 20:19:45droundysetstatus: unknown -> resolved
nosy: droundy, kowey, dagit, dmitry.kurochkin, kili
2008-09-06 14:10:48kilisetstatus: resolved -> unknown
nosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5922
files: + ms.sh
2008-09-07 11:54:29koweysetnosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5927
2008-09-07 21:52:19dmitry.kurochkinsetnosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5930
assignedto: dmitry.kurochkin ->
2008-09-08 13:56:50droundysetnosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5937
2008-09-09 07:45:47koweysetpriority: bug -> urgent
status: unknown -> needs-reproduction
topic: + IncludesExampleOrTest
messages: + msg5960
nosy: droundy, kowey, dagit, dmitry.kurochkin, kili
2008-09-10 11:19:29dmitry.kurochkinsetnosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5973
2008-09-10 13:01:12koweysetstatus: needs-reproduction -> resolved-in-unstable
nosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5974
2008-09-10 21:00:30kilisetnosy: droundy, kowey, dagit, dmitry.kurochkin, kili
messages: + msg5978
2009-04-22 03:33:49twbsetstatus: resolved-in-unstable -> resolved
nosy: + simon, thorkilnaur
2009-08-06 17:59:58adminsetnosy: + markstos, jast, Serware, darcs-devel, zooko, mornfall, tommy, beschmi, - droundy, kili
2009-08-06 21:12:11adminsetnosy: - beschmi
2009-08-10 21:48:01adminsetnosy: + kili, - tommy, markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:44:22adminsetnosy: - dagit
2009-08-25 17:44:28adminsetnosy: + darcs-devel, - simon
2009-08-27 14:19:01adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, kili
2010-06-15 21:48:16adminsetmilestone: 2.1.x
2010-06-15 21:48:18adminsettopic: - Target-2.1