darcs

Issue 1053 task: audit filepath code

Title task: audit filepath code
Priority wishlist Status wont-fix
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, jaredj, kowey, thorkilnaur, twb
Assigned To
Topics ProbablyEasy

Created on 2008-09-01.09:48:08 by kowey, last changed 2009-08-27.14:28:07 by admin.

Files
File name Uploaded Type Edit Remove
unnamed kowey, 2008-09-01.09:48:06 message/rfc822
Messages
msg5860 (view) Author: kowey Date: 2008-09-01.09:48:06
In the (hopefully) attached message, Neil Mitchell suggests some tips
for verifying that System.FilePath is compatible with darcs.  Sounds
like this would be worth doing.

I recommend that we start from the outside in (for example, leave
FileName alone for a while, at least those functions which are used by
Darcs.Patch but maybe attack RepoPath and FilePathUtils first)
Attachments
msg7553 (view) Author: twb Date: 2009-03-29.06:50:38
On Sun, Aug 31, 2008 at 10:48:06PM +0000, Eric Kow wrote:
> In the (hopefully) attached message, Neil Mitchell suggests some tips
> for verifying that System.FilePath is compatible with darcs.  Sounds
> like this would be worth doing.

Per Neil's comments, I got a checkout of the filepath repo.

    darcs get http://darcs.haskell.org/libraries/filepath/

Unfortunately "cabal test" does not work, and test/ only contains a
Windows script to perform testing.  Translating it by hand, I tried

    cd test
    runghc GenTests
    ghci -i.. -cpp -DTESTING FilePath_Test.hs

I get this:

    AutoTest.hs:8:31: Module `Test.QuickCheck' does not export `check'
    Failed, modules loaded: none.

I guess this is because filepath isn't compatible with QuickCheck 2,
and versioned imports are provided at the cabal level and don't have
any effect when you manually use ghci as above.

So: I give up.  Someone else can look into this further.
msg8288 (view) Author: kowey Date: 2009-08-19.11:07:55
Too late; we've already started using FilePath and in any case, I don't think
we'll *ever* get around to this.
History
Date User Action Args
2008-09-01 09:48:08koweycreate
2008-09-01 09:48:33koweysetpriority: wishlist
nosy: + jaredj
topic: + ProbablyEasy
2009-03-29 06:50:41twbsetstatus: unread -> unknown
nosy: + twb, dmitry.kurochkin, simon, thorkilnaur
messages: + msg7553
2009-08-10 23:44:39adminsetnosy: - dagit
2009-08-19 11:07:59koweysetstatus: unknown -> wont-fix
nosy: kowey, simon, twb, thorkilnaur, jaredj, dmitry.kurochkin
messages: + msg8288
2009-08-25 17:42:42adminsetnosy: + darcs-devel, - simon
2009-08-27 14:28:07adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, jaredj, dmitry.kurochkin