darcs

Issue 1056 darcs unrecord --no-deps

Title darcs unrecord --no-deps
Priority wishlist Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur
Assigned To
Topics Matchers

Created on 2008-09-02.22:29:56 by dagit, last changed 2009-08-27.14:28:15 by admin.

Messages
msg5887 (view) Author: dagit Date: 2008-09-02.22:29:54
$ darcs unrecord --matches='author dagit'
Mon Sep  1 23:08:33 PDT 2008  Jason Dagit <dagit@codersbase.com>
  * make commands use RIO
Shall I unrecord this patch? (1/63)  [ynWvpxdaqjk], or ? for help: y
Mon Sep  1 17:32:54 PDT 2008  Jason Dagit <dagit@codersbase.com>
  * resolve conflicts
Shall I unrecord this patch? (2/63)  [ynWvpxdaqjk], or ? for help: y
Sat Aug 30 10:47:22 PDT 2008  David Roundy <droundy@darcs.net>
  * fix bug in makeRelative.
Shall I unrecord this patch? (3/63)  [ynWsfvpxdaqjk], or ? for help:

The last patch listed is not by author dagit.
msg5888 (view) Author: kowey Date: 2008-09-02.22:44:05
On Tue, Sep 02, 2008 at 22:29:57 -0000, Jason Dagit wrote:
> The last patch listed is not by author dagit.

I'm too tired to find the corresponding bug right now, but this is
another UI problem.

That last patch is later depended on by some other patch by author dagit
which you /may/ want to unrecord, but in order to unrecord that patch,
you'd have to also unrecord David's
msg5889 (view) Author: kowey Date: 2008-09-02.22:48:08
On Tue, Sep 02, 2008 at 23:43:49 +0100, Eric Y. Kow wrote:
> That last patch is later depended on by some other patch by author dagit
> which you /may/ want to unrecord, but in order to unrecord that patch,
> you'd have to also unrecord David's

Also, I wonder if darcs pull --no-deps could be usefully adapted
msg5903 (view) Author: daveroundy Date: 2008-09-04.14:19:35
On Tue, Sep 2, 2008 at 6:29 PM, Jason Dagit <bugs@darcs.net> wrote:
> $ darcs unrecord --matches='author dagit'
> Mon Sep  1 23:08:33 PDT 2008  Jason Dagit <dagit@codersbase.com>
>  * make commands use RIO
> Shall I unrecord this patch? (1/63)  [ynWvpxdaqjk], or ? for help: y
> Mon Sep  1 17:32:54 PDT 2008  Jason Dagit <dagit@codersbase.com>
>  * resolve conflicts
> Shall I unrecord this patch? (2/63)  [ynWvpxdaqjk], or ? for help: y
> Sat Aug 30 10:47:22 PDT 2008  David Roundy <droundy@darcs.net>
>  * fix bug in makeRelative.
> Shall I unrecord this patch? (3/63)  [ynWsfvpxdaqjk], or ? for help:
>
> The last patch listed is not by author dagit.

Why do you consider this a bug? I consider it a feature that you can
use unrecord --match to unrecord both a patch and any patches that
depend on it.

David
msg5906 (view) Author: dagit Date: 2008-09-04.19:38:19
On Thu, Sep 4, 2008 at 7:19 AM, David Roundy <bugs@darcs.net> wrote:
>
> David Roundy <daveroundy@gmail.com> added the comment:
>
> On Tue, Sep 2, 2008 at 6:29 PM, Jason Dagit <bugs@darcs.net> wrote:
>> $ darcs unrecord --matches='author dagit'
>> Mon Sep  1 23:08:33 PDT 2008  Jason Dagit <dagit@codersbase.com>
>>  * make commands use RIO
>> Shall I unrecord this patch? (1/63)  [ynWvpxdaqjk], or ? for help: y
>> Mon Sep  1 17:32:54 PDT 2008  Jason Dagit <dagit@codersbase.com>
>>  * resolve conflicts
>> Shall I unrecord this patch? (2/63)  [ynWvpxdaqjk], or ? for help: y
>> Sat Aug 30 10:47:22 PDT 2008  David Roundy <droundy@darcs.net>
>>  * fix bug in makeRelative.
>> Shall I unrecord this patch? (3/63)  [ynWsfvpxdaqjk], or ? for help:
>>
>> The last patch listed is not by author dagit.
>
> Why do you consider this a bug? I consider it a feature that you can
> use unrecord --match to unrecord both a patch and any patches that
> depend on it.

I wanted to unrecord my patches not yours.  Instead I had to skip
through many patches to find it and then unrecord it.  It's good that
this is safe but when I'm picking the patch I want the filtering to
restrict the high level view to exactly that which I'm filtering on.
If the patch I end up picking has dependencies I didn't pick I think
that's a better time to show me.

filtering must be bugging and then I'm afraid to use it.

I hope that clarifies.

Jason
msg5907 (view) Author: kowey Date: 2008-09-04.19:44:04
On Thu, Sep 04, 2008 at 12:38:01 -0700, Jason Dagit wrote:
> I wanted to unrecord my patches not yours.  Instead I had to skip
> through many patches to find it and then unrecord it.  It's good that
> this is safe but when I'm picking the patch I want the filtering to
> restrict the high level view to exactly that which I'm filtering on.
> If the patch I end up picking has dependencies I didn't pick I think
> that's a better time to show me.

I think we want darcs unrecord --no-deps
See darcs help pull --no-deps
msg5910 (view) Author: droundy Date: 2008-09-04.22:10:25
On Thu, Sep 04, 2008 at 08:43:49PM +0100, Eric Y. Kow wrote:
> On Thu, Sep 04, 2008 at 12:38:01 -0700, Jason Dagit wrote:
> > I wanted to unrecord my patches not yours.  Instead I had to skip
> > through many patches to find it and then unrecord it.  It's good
> > that this is safe but when I'm picking the patch I want the
> > filtering to restrict the high level view to exactly that which
> > I'm filtering on.  If the patch I end up picking has dependencies
> > I didn't pick I think that's a better time to show me.
>
> I think we want darcs unrecord --no-deps
> See darcs help pull --no-deps

That would work.  But the default should be to include the deps,
for the same reason that the default is to be interactive.  Users will
be more confused if they try

darcs unrecord -p buggy-patch

and it simply claims that the patch doesn't exist, when

darcs changes -p buggy-patch

clearly show that the patch does exist.

David
msg8291 (view) Author: kowey Date: 2009-08-19.12:02:28
I see that we now have a darcs unrecord --no-deps feature, so I'm closing this
History
Date User Action Args
2008-09-02 22:29:56dagitcreate
2008-09-02 22:44:07koweysetstatus: unread -> unknown
messages: + msg5888
2008-09-02 22:48:10koweysetmessages: + msg5889
2008-09-04 14:19:37daveroundysetnosy: + daveroundy
messages: + msg5903
2008-09-04 19:38:22dagitsetnosy: kowey, dagit, daveroundy
messages: + msg5906
2008-09-04 19:44:06koweysetnosy: kowey, dagit, daveroundy
messages: + msg5907
2008-09-04 22:10:27droundysetnosy: + droundy
messages: + msg5910
2008-09-16 23:08:03droundysetpriority: feature
nosy: droundy, kowey, dagit, daveroundy
2008-09-16 23:08:13droundysetpriority: feature -> wishlist
nosy: droundy, kowey, dagit, daveroundy
2008-09-28 20:50:07adminsetnosy: + thorkilnaur, simon, - daveroundy
2009-08-06 18:00:09adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, tommy, beschmi, - droundy
2009-08-06 21:12:20adminsetnosy: - beschmi
2009-08-10 21:48:14adminsetnosy: - tommy, markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:44:45adminsetnosy: - dagit
2009-08-19 12:02:31koweysetstatus: unknown -> resolved
nosy: kowey, simon, thorkilnaur, dmitry.kurochkin
topic: + Matchers
messages: + msg8291
title: darcs unrecord --match=... doesn't restrict to only matches -> darcs unrecord --no-deps
2009-08-25 17:29:38adminsetnosy: + darcs-devel, - simon
2009-08-27 14:28:15adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin