darcs

Issue 1083 DARCS_DO_COLOR_LINES=True fights with \XX escape color

Title DARCS_DO_COLOR_LINES=True fights with \XX escape color
Priority bug Status given-up
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, twb
Assigned To
Topics

Created on 2008-09-19.14:50:44 by twb, last changed 2017-07-30.23:02:38 by gh.

Messages
msg6050 (view) Author: twb Date: 2008-09-19.14:50:41
I use

    export DARCS_DO_COLOR_LINES=True

In the example output of "darcs whatsnew" below, lines beginning with
a plus are cyan, and the escaped copyright symbols are red. But AFTER
the escape characters, the rest of the line is white; it should be
cyan.

Basically, after the escape a "reset colors" code is sent, which
resets both the red AND the cyan.  For this to behave properly, darcs
needs to remember internally a color "stack" and pop from it instead
of just sending the sgr0 code when popping to a non-empty stack.

    hunk ./debian/copyright 15
    +Files: debian/*
    +Copyright: \c2\a9 2003-2005, David Roundy <droundy@abridgegame.org>
    +Copyright: \c2\a9 2008, Trent W. Buck <trentbuck@gmail.com>
    +License: GPL-any
    + You are free to distribute this software under the terms of
    + the GNU General Public License.
    + On Debian systems, the complete text of the GNU General Public
    + License can be found in /usr/share/common-licenses/GPL file.
msg8513 (view) Author: kowey Date: 2009-08-26.14:16:27
There is another printer and escape related bug in issue1442 if whoever works on
this is interested.
History
Date User Action Args
2008-09-19 14:50:44twbcreate
2008-09-21 12:37:52droundysetpriority: bug
nosy: + simon
2009-04-09 14:07:42koweysetstatus: unread -> needs-reproduction
nosy: + dmitry.kurochkin, thorkilnaur
2009-08-10 23:45:50adminsetnosy: - dagit
2009-08-25 17:25:05adminsetnosy: + darcs-devel, - simon
2009-08-26 14:16:29koweysetstatus: needs-reproduction -> needs-implementation
nosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin
messages: + msg8513
2009-08-27 14:33:17adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin
2017-07-30 23:02:38ghsetstatus: needs-implementation -> given-up