Issue 1084 patch tracker

Title patch tracker
Priority feature Status resolved
Milestone Resolved in
Superseder add patch-tracking features to roundup, darcswatch - requests from darcs team, review-board/darcs integration
View: 1571, 1602, 1570
Nosy List Serware, WorldMaker, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, twb
Assigned To
Topics BugTracker

Created on 2008-09-19.22:24:11 by dagit, last changed 2009-10-27.09:54:06 by kowey.

msg6055 (view) Author: dagit Date: 2008-09-19.22:24:07
Here is what I'm concretely proposing while admitting that I
don't yet know how much of this is possible:

1) We create the domain patches.darcs.net and it points at the bug
tracker (this is simply for consistency).
2) We create the email address patches@darcs.net to match
bugs@darcs.net (I can moderate this like I do darcs-users and bugs
3) We change the address for darcs send to patches@darcs.net
4) We add a new issue type, 'patch' to roundup.  IssueXXX can
reference patchYYY in it's description and vice versa.
5) We teach roundup how to look for status update commands in emails
for specific issues and patches.
6) New patch submissions are sent to darcs-users@ and droundy@ by
roundup instead of darcs send.
7) People have the option of replying to emails about the patch or
using roundup at http://patches.darcs.net/patchYYY

I need your feedback because I don't want to change your workflow or
make a hassle for you.  I need to know if the above changes would
negatively impact you but I don't know enough about how you apply

I was imagining that with the above setup it works like this:

I send in a patch to patches@darcs.net and it is assigned patch42 and
forwarded to darcs-users@.  Once the message gets to darcs-users@ you
respond with some feedback requesting an amend.  In your email you say
something like this, "roundup: patch42 amend required".  We can decide
on the syntax later.  This updates the patch status.  I revise the
patch and darcs send with, "roundup: patch42 amended" in the email or
I visit http://patches.darcs.net/patch42 and attach my amended patch
and you receive a new email with the patch attached.  We iterate like
this for a while, and then eventually you say, "Applied.  Thanks!" and
add "roundup: patch42 applied".  Now at
http://patches.darcs.net/patch42 we have the full history and I'm
happy.  Hopefully you are happy because you were able to continue
working via email with the minor modification of embedding status
updates in your emails.  Perhaps some of these status updates could
even be done via post-hooks or mutt commands.
msg6056 (view) Author: simon Date: 2008-09-19.23:04:36
Jason & I discussed this on irc. Here's my take on what we agreed:

The basic wish is to have a tool that monitors our patch mails and  
provides a nice web-based overview of unapplied patches.

The goal is to reduce confusion and effort when there are many  
(versions of) proposed patches flying around, to provide a more  
efficient interface for those patch reviewers/appliers that prefer a  
web interface, and down the road perhaps to offer other useful features.

Some existing patch trackers to look at are http://bundlebuggy.aaronbentley.com/help 
  and http://patchwork.ozlabs.org/project/linux-kernel/list/ .

In our world, we have a number of tools that do parts of this already  
(darcs, darcswatch, mailman, roundup). Since we are successfully using  
roundup already and it is close to what we need, we agreed to try and  
minimally extend it to get a good-enough patch tracker version 1.

I added a patch type to roundup. It works just like an issue with a  
few less fields. I then tried to send a patch to the tracker like so:

   darcs send http://darcs.net --to='bugs@darcs.net' -- 
subject='[patch] test, please ignore' -p 'test change' -a

The [patch] in the subject should cause roundup to create a new patch,  
but this turns out to be broken in roundup 1.2.1. I stopped here as I  
don't have permission to upgrade or fix it. The following temporary  
fix might be sufficient: at /usr/lib/python2.4/site-packages/roundup/ 
mailgw.py line 621, add \] after the ^.

Or, the latest 1.4.6 looks like it should work better. I do think it  
is worthwhile for us to upgrade roundup at this point, and I'm willing  
to do this or help David do it. Changes are at http://roundup.cvs.sourceforge.net/roundup/roundup/CHANGES.txt?view=markup&content-type=text/vnd.viewcvs-markup&revision=HEAD 

Once the above is resolved, the tracker should be able to receive and  
store patches and they will be visible with the admin tool and  
addressible by email. From there it should be straightforward to add  
some web views, similar to the issue views or completely different.
msg6101 (view) Author: simon Date: 2008-09-23.19:51:41
Responding to kowey's aside on [issue1078]:

> (ahah! perhaps further evidence that we need a patch tracker... one
> which integrates with the bugtracker)

I'm ready to explore this further, waiting only for permissions help  
as described above.

But also, wearing my less-is-more hat I note that one could have cc'd  
that issue 1078 patch to the bugtracker with [issue1078] in the  
subject, and it would now be attached to that issue as a file. One  
could still have a separate web view summarizing these patch files.  
That seems an alternative to having a separate patch type, with  
possibly a few advantages worth thinking about.
msg6550 (view) Author: kowey Date: 2008-10-31.09:27:51
Simon: could you clarify what the requested next action for David is, please?
msg6583 (view) Author: kowey Date: 2008-11-04.10:58:58
Hi David,

Simon requested that we upgrade to Roundup 1.4.6.

Any objections in principle?

Trent suggests you might have a 'technical' objection, in the sense that the
server is running Etch and so it would not be a simple matter of apt-get
install.  If this was the case, if somebody were to put together a backport, or
somehow do some alternative installation methed, would that be acceptable?
msg6596 (view) Author: simon Date: 2008-11-05.19:48:46
Hi.. I'm still happy to look at this but don't have time yet. It's possible David 
already gave me enough access to do it at least as a trial. If someone else 
(markstos, lispy ?) wants to have a crack at it sooner, feel free.
msg6597 (view) Author: dagit Date: 2008-11-05.20:02:32
On Wed, Nov 5, 2008 at 11:48 AM, Simon Michael <bugs@darcs.net> wrote:
> Simon Michael <simon@joyful.com> added the comment:
> Hi.. I'm still happy to look at this but don't have time yet. It's possible David
> already gave me enough access to do it at least as a trial. If someone else
> (markstos, lispy ?) wants to have a crack at it sooner, feel free.

Hi Simon,

Given my relative lack of experience with roundup I would prefer to
delegate this task to someone more experienced (you!).  Do you have an
estimate on when you'll next have time for this?  That would help me
gauge the next step in realizing the patch tracker.

msg6599 (view) Author: simon Date: 2008-11-05.21:05:20
We discussed this on irc, and I have moved a little further with issue1097. I 
suggest we table this issue until issue1097 is complete, since I don't want to 
keep applying fixes and customisations to an obsolete roundup version.
msg7958 (view) Author: simon Date: 2009-07-14.21:28:42
Update: we upgraded roundup to 1.4.4, but I'm not working on a patch tracker. Note 
the roundup project is currently working on hg and svn integration, and interested 
in adding darcs to that list.
msg8048 (view) Author: kowey Date: 2009-08-09.10:06:15
Assigning to Max to look into building Review-Board/darcs integration:

msg8257 (view) Author: kowey Date: 2009-08-18.16:37:30
I only just now realised that you can look at reviewboard in action without
having to log in.  See for example the KDE instance:


It appears that review-board knows how to point to issue trackers.  In
principle, I think it should be possible to add a reviewboard number to roundup
as well for full integration.

For now, I'm assuming that getting darcs-reviewboard integration is the best
course of action whenever Max or anybody else has a chance to look into it.
msg8512 (view) Author: kowey Date: 2009-08-26.14:10:49
I'm splitting off all the review-board talk to issue1570 and the roundup talk to

We can keep this around as a parent ticket for other ways of getting a
patch-tracker, eg. darcswatch
msg9062 (view) Author: kowey Date: 2009-10-27.09:54:05
Resolved through resolution of issue1571
Date User Action Args
2008-09-19 22:24:11dagitcreate
2008-09-19 23:04:39simonsetstatus: unread -> unknown
nosy: + simon
messages: + msg6056
title: wish: patch tracker -> status
2008-09-19 23:07:18simonsetstatus: unknown -> unread
nosy: + daveroundy
assignedto: daveroundy
2008-09-19 23:08:01simonsetnosy: kowey, dagit, simon, daveroundy
title: status -> patch tracker
2008-09-19 23:26:57simonsetstatus: unread -> unknown
nosy: kowey, dagit, simon, daveroundy
2008-09-23 19:51:43simonsetnosy: kowey, dagit, simon, daveroundy
messages: + msg6101
2008-09-23 20:07:59simonsettopic: + BugTracker
nosy: + Serware
2008-09-28 20:26:18simonsetnosy: + droundy, thorkilnaur, - daveroundy
assignedto: daveroundy -> droundy
2008-10-31 09:27:53koweysetnosy: + dmitry.kurochkin
messages: + msg6550
2008-10-31 09:28:17koweysetpriority: wishlist -> feature
nosy: droundy, kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, Serware
2008-11-04 10:59:00koweysetnosy: + twb
messages: + msg6583
2008-11-05 19:48:48simonsetnosy: droundy, kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin, Serware
messages: + msg6596
2008-11-05 20:02:35dagitsetnosy: + serware
messages: + msg6597
2008-11-05 21:05:23simonsetnosy: droundy, kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin, serware, Serware
messages: + msg6599
assignedto: droundy -> (no value)
2008-11-06 12:01:27droundysetnosy: - droundy
2008-11-19 17:33:59simonsetnosy: kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin, serware, Serware
assignedto: simon
2009-07-14 21:28:45simonsetnosy: kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin, serware, Serware
messages: + msg7958
2009-08-09 10:06:18koweysetnosy: + WorldMaker
messages: + msg8048
assignedto: simon -> WorldMaker
2009-08-10 23:45:52adminsetnosy: - dagit
2009-08-18 16:37:32koweysetstatus: unknown -> needs-reproduction
nosy: kowey, simon, twb, WorldMaker, thorkilnaur, dmitry.kurochkin, serware, Serware
messages: + msg8257
2009-08-25 17:24:41adminsetnosy: + darcs-devel, - simon
2009-08-26 14:10:51koweysetstatus: needs-reproduction -> waiting-for
nosy: kowey, darcs-devel, twb, WorldMaker, thorkilnaur, dmitry.kurochkin, serware, Serware
superseder: + review-board/darcs integration, add patch-tracking features to roundup
messages: + msg8512
assignedto: WorldMaker ->
2009-08-27 14:33:13adminsetnosy: kowey, darcs-devel, twb, WorldMaker, thorkilnaur, dmitry.kurochkin, serware, Serware
2009-09-09 12:32:52koweysetnosy: kowey, darcs-devel, twb, WorldMaker, thorkilnaur, dmitry.kurochkin, serware, Serware
superseder: + darcswatch - requests from darcs team
2009-10-23 22:39:04adminsetnosy: + maxbattcher, - WorldMaker
2009-10-23 22:44:55adminsetnosy: - Serware
2009-10-23 23:27:58adminsetnosy: + Serware, - serware
2009-10-24 00:00:27adminsetnosy: + WorldMaker, - maxbattcher
2009-10-27 09:54:06koweysetstatus: waiting-for -> resolved
messages: + msg9062