darcs

Issue 1089 darcs changes --last doesn't count as expected

Title darcs changes --last doesn't count as expected
Priority bug Status given-up
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, mornfall, thorkilnaur
Assigned To
Topics Matchers, UI

Created on 2008-09-20.07:00:19 by simon, last changed 2017-07-31.00:04:11 by gh.

Messages
msg6063 (view) Author: simon Date: 2008-09-20.07:00:17
darcs changes somefile --last 10 shows the subset of the last 10 patches that
affect somefile. It should show the last 10 patches that touched somefile,
because this is more intuitive to users and more often what you want.
msg6169 (view) Author: mornfall Date: 2008-09-29.12:50:09
Ack, I run into this every so often. I'll look into fixing this: however, if
anyone feels like fixing, go ahead, I am ever so short on time, so don't expect
quick turnaround. Sorry... (Feel free to reassign to yourself in that case.)
msg7854 (view) Author: mornfall Date: 2009-05-29.18:40:49
There's now changes --max-count that implements the behaviour you are looking
for. You may want to make a case for replacing the --last behaviour with --max-
since the max-count implementation should be fairly efficient, I don't think
that speed would be an argument in favour of keeping the --last as it is, only
possible UI confusion ... Eric, what do you think?)
msg7855 (view) Author: kowey Date: 2009-05-29.20:50:28
I think there is a use for --last, which is to limit the search within the last
N patches.

This is probably a question for darcs-users.

For the moment, I'm happy to just leave it resolved.
msg12220 (view) Author: kowey Date: 2010-08-18.13:05:52
There is a current proposal to

* remove the current --last matcher

* rename --max-count to the newly vacant --last

* suggest users who want the current --last to use --index=1-N instead; 
note that making this choice means that we'd be stuck with --number that 
counts backwards, cf. issue1484.  Alternatively, we could just do 
without.

The patch is further.  I suggest we discuss this further on darcs-users 
and/or a Darcs Hacking Sprint to make progress

Background: http://irclog.perlgeek.de/darcs/2010-08-18#i_2718230 (stop 
at 12:50)

BTS training: this ticket is marked need-action, which means we have a 
concrete action in mind.  In this case, the action is "hold a discussion 
on the proposed change".  After the dust has settled, you can flip the 
bug to "need-implementation".  Not all UI changes need discussion.  
Sometimes at your discretion you can decide that it's more expedient to 
have the implementation first and the discussion after that.
History
Date User Action Args
2008-09-20 07:00:19simoncreate
2008-09-29 12:50:10mornfallsetnosy: + mornfall, thorkilnaur
messages: + msg6169
assignedto: mornfall
2009-05-29 18:40:52mornfallsetnosy: + dmitry.kurochkin
messages: + msg7854
2009-05-29 20:50:31koweysetstatus: unknown -> resolved
nosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, mornfall
messages: + msg7855
2009-08-10 23:46:04adminsetnosy: - dagit
2009-08-25 17:24:51adminsetnosy: + darcs-devel, - simon
2009-08-27 14:20:24adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, mornfall
2010-08-18 13:05:54koweysetstatus: resolved -> needs-reproduction
assignedto: mornfall ->
topic: + UI, Matchers
messages: + msg12220
2017-07-31 00:04:11ghsetstatus: needs-reproduction -> given-up