darcs

Issue 1118 Not showing prompt when asking for patch name

Title Not showing prompt when asking for patch name
Priority bug Status given-up
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, marcot, thorkilnaur, twb
Assigned To
Topics

Created on 2008-10-02.15:39:05 by marcot, last changed 2009-08-30.14:49:48 by kowey.

Messages
msg6202 (view) Author: marcot Date: 2008-10-02.15:39:03
When I create a new repository with --darcs-2 and press a lot of y, then an a,
it shows the next change and asks if I want to record it, instead of going to
the patch name prompt.  But when I press a again, it goes to the next line and
nothing is shown.  I press Enter, and it shows both the patch name prompt and
the long description prompt, but I can answer only the last one.

addfile ./scripts/9/rules
Shall I record this change? (111/120)  [ynWsfvpxdaqjk], or ? for help: a
hunk ./scripts/9/rules 1
+#!/usr/bin/make -f
+# Generic Haskell cabal library debian/rules v9 by Ian Lynagh,
+# based on the example by Joey Hess.
+# This file is public domain software.
+
+# Uncomment this to turn on verbose mode.
+#export DH_VERBOSE=1
+
+# Get the Cabal package name, lower-cased.
+# Assumes that the Debian package name is standard.
+CABAL_PACKAGE = $(shell dpkg-parsechangelog | sed "1s/source: haskell-//i; q")
+
+GHC6_PACKAGE      = libghc6-$(CABAL_PACKAGE)-dev
+GHC6_PROF_PACKAGE = libghc6-$(CABAL_PACKAGE)-prof
+GHC6_DOC_PACKAGE  = libghc6-$(CABAL_PACKAGE)-doc
+
+# Find ghc. The ghc in the path might point to some other version of
+# GHC, so use ghc6 if it exists (which it ought to when building for
+# Debian)
+GHC := $(firstword $(shell bash -c "type -p ghc6 ghc"))
+
+CONFIGURE_OPTS  = --enable-library-vanilla \
+                  --enable-library-profiling \
+                  --enable-library-for-ghci
+ifneq '$(findstring $(shell dpkg-architecture -qDEB_HOST_ARCH), i386 amd64)' ''
+CONFIGURE_OPTS += --enable-split-objs
+endif
+
+build: build-stamp
+build-stamp:
+       dh_testdir
+
+       update-haskell-control --check
+       $(GHC) --make Setup.*hs -o setup-ghc
+       ./setup-ghc configure --ghc --with-compiler=$(GHC) --prefix=/usr
--docdir=/usr/share/doc/ghc6-doc/libraries/$(CABAL_PACKAGE) 
--htmldir=/usr/share/doc/ghc6-doc/libraries/$(CABAL_PACKAGE) $(CONFIGURE_OPTS)
+       ./setup-ghc build
+       ./setup-ghc haddock --hyperlink-source
+
+       touch $@
+
+FILES = -type f
+PROF_FILE = \( -name "*.p_*" -o -name "lib*_p.a" \)
+
+install: install-stamp
+install-stamp: build-stamp
+       dh_testdir
+       dh_testroot
+       dh_clean -k
+       dh_installdirs
+
+       ./setup-ghc copy --destdir=debian/tmp/
+       # XXX The file isn't necessarily called LICENSE, and may not even
+       # exist at all
+       rm debian/tmp/usr/share/doc/ghc6-doc/libraries/$(CABAL_PACKAGE)/LICENSE
+       find debian/tmp/usr/lib -type f ! $(PROF_FILE) \
+                                        > debian/$(GHC6_PACKAGE).install
+       find debian/tmp -type d -empty  >> debian/$(GHC6_PACKAGE).install
+       find debian/tmp/usr/lib -type f   $(PROF_FILE) \
+                                        > debian/$(GHC6_PROF_PACKAGE).install
+       echo "debian/tmp/usr/share/doc"  > debian/$(GHC6_DOC_PACKAGE).install
+
+       ./setup-ghc register --gen-script 
+       ./setup-ghc unregister --gen-script
+       mkdir -p         debian/$(GHC6_PACKAGE)/usr/lib/$(GHC6_PACKAGE)
+       mv register.sh   debian/$(GHC6_PACKAGE)/usr/lib/$(GHC6_PACKAGE)
+       mv unregister.sh debian/$(GHC6_PACKAGE)/usr/lib/$(GHC6_PACKAGE)
+
+       touch $@
+
+update-generated-files:
+       update-debian-haskell-files
+       update-haskell-control
+       sed "s/@PACKAGE@/$(GHC6_PACKAGE)/g" debian/$(GHC6_PACKAGE).prerm.in \
+                                         > debian/$(GHC6_PACKAGE).prerm
+       sed "s/@PACKAGE@/$(GHC6_PACKAGE)/g" debian/$(GHC6_PACKAGE).postinst.in \
+                                         > debian/$(GHC6_PACKAGE).postinst
+
+clean:
+       dh_testdir
+       dh_testroot
+       rm -f build-stamp install-stamp binary-common-stamp
+
+       -./setup-ghc clean
+       rm -f Setup.o Setup.hi setup-ghc  
+       rm -f debian/*.install
+
+       dh_clean
+
+# Build architecture-dependent files here.
+binary-common: binary-common-stamp
+binary-common-stamp: install-stamp
+       dh_testdir
+       dh_testroot
+       dh_installchangelogs
+       dh_installdocs
+       dh_installexamples
+       dh_install --fail-missing
+#      dh_installmenu
+#      dh_installdebconf^I$
+#      dh_installlogrotate
+#      dh_installemacsen
+#      dh_installcatalogs
+#      dh_installpam
+#      dh_installmime
+#      dh_installinit
+#      dh_installcron
+#      dh_installinfo
+#      dh_undocumented
+       dh_installman
+       dh_link
+       dh_strip
+       dh_compress -X.haddock
+       dh_fixperms
+#      dh_perl
+#      dh_python
+#      dh_makeshlibs
+       dh_installdeb
+       dh_shlibdeps
+       dh_gencontrol
+       dh_md5sums
+       dh_builddeb
+
+# binary-indep and binary-arch both build everything, as otherwise
+# # "dh_install --fail-missing" falls over
+
+# Build architecture-independent files here.
+binary-indep: binary-common-stamp
+# We have nothing to do by default.
+
+# Build architecture-dependent files here.
+binary-arch: binary-common-stamp
+
+binary: binary-indep binary-arch
+.PHONY: build clean binary-indep binary-arch binary-common binary install
Shall I record this change? (112/120)  [ynWsfvpxdaqjk], or ? for help: a

What is the patch name? Do you want to add a long comment? [yn]n
Finished recording patch 'a'

The repository from this example is at http://marcot.iaaeee.org/haskell-utils/
msg7196 (view) Author: twb Date: 2009-01-26.01:33:41
Hi Marco, thanks for your bug report!  Sorry to make you wait for a response.

On Thu, Oct 02, 2008 at 04:39:03AM +0000, Marco Túlio Gontijo e Silva wrote:
> When I create a new repository with --darcs-2 and press a lot of y, then an a,
> it shows the next change and asks if I want to record it, instead of going to
> the patch name prompt.  But when I press a again, it goes to the next line and
> nothing is shown.  I press Enter, and it shows both the patch name prompt and
> the long description prompt, but I can answer only the last one.
>
> Shall I record this change? (111/120)  [ynWsfvpxdaqjk], or ? for help: a
> [...]
> Shall I record this change? (112/120)  [ynWsfvpxdaqjk], or ? for help: a
>
> What is the patch name? Do you want to add a long comment? [yn]n
> Finished recording patch 'a'
>
> The repository from this example is at http://marcot.iaaeee.org/haskell-utils/

This is not a behaviour I have encountered before.  Can you reproduce it reliably?
What does darcs --version say?  Can you reproduce this problem with the current
release, Darcs 2.2.0?  Can you reproduce the problem in a new, empty repo?
msg7213 (view) Author: marcot Date: 2009-01-26.14:13:54
Hello Trent,

thanks for your answer.

Em Seg, 2009-01-26 às 01:33 +0000, Trent Buck escreveu:
> Trent Buck <trentbuck@gmail.com> added the comment:
> On Thu, Oct 02, 2008 at 04:39:03AM +0000, Marco Túlio Gontijo e Silva wrote:
> > When I create a new repository with --darcs-2 and press a lot of y, then an a,
> > it shows the next change and asks if I want to record it, instead of going to
> > the patch name prompt.  But when I press a again, it goes to the next line and
> > nothing is shown.  I press Enter, and it shows both the patch name prompt and
> > the long description prompt, but I can answer only the last one.
> >
> > Shall I record this change? (111/120)  [ynWsfvpxdaqjk], or ? for help: a
> > [...]
> > Shall I record this change? (112/120)  [ynWsfvpxdaqjk], or ? for help: a
> >
> > What is the patch name? Do you want to add a long comment? [yn]n
> > Finished recording patch 'a'
> >
> > The repository from this example is at http://marcot.iaaeee.org/haskell-utils/
> 
> This is not a behaviour I have encountered before.  Can you reproduce it reliably?

I tried here several times, and I could reproduce it only once, so it
seems to be an ocasional bug.

> What does darcs --version say?

marcot@quindinho:~/Modelos/darcs$ darcs --version
2.2.0 (release)

> Can you reproduce this problem with the current
> release, Darcs 2.2.0?

The test I've made today was using this version.

>   Can you reproduce the problem in a new, empty repo?

Yes, I've done it just now.

$ for i in `seq 100`; do touch $i; done
$ darcs init
$ darcs add *
$ darcs record

Greetings.
msg7323 (view) Author: twb Date: 2009-02-16.23:45:29
On Sun, Jan 25, 2009 at 02:33:41PM +0000, Trent Buck wrote:
> Hi Marco, thanks for your bug report!  Sorry to make you wait for a response.
> 
> On Thu, Oct 02, 2008 at 04:39:03AM +0000, Marco Túlio Gontijo e Silva wrote:
> > When I create a new repository with --darcs-2 and press a lot of y, then an a,
> > it shows the next change and asks if I want to record it, instead of going to
> > the patch name prompt.  But when I press a again, it goes to the next line and
> > nothing is shown.  I press Enter, and it shows both the patch name prompt and
> > the long description prompt, but I can answer only the last one.
> >
> > Shall I record this change? (111/120)  [ynWsfvpxdaqjk], or ? for help: a
> > [...]
> > Shall I record this change? (112/120)  [ynWsfvpxdaqjk], or ? for help: a
> >
> > What is the patch name? Do you want to add a long comment? [yn]n
> > Finished recording patch 'a'

Something that should have been obvious to me before: if you answer
"a" to "Shall I record this change?", Darcs should not ask about
recording any more patches.

For example, here's what I get:

    $ darcs init
    $ touch x y
    $ darcs rec -l
    addfile ./x
    Shall I record this change? (1/2)  [ynWsfvplxdaqjk], or ? for help: a

    What is the patch name? foo
    Finished recording patch 'foo'
    $
msg8519 (view) Author: kowey Date: 2009-08-26.17:27:05
This bug is very odd and hard to reproduce :-(
Marco, do you still get the same symptoms Darcs 2.3?

I could not reproduce it with your script.  I tried hitting 'y' a lot of times
and then 'a' but each time it hitting 'a' jumps straight to the patch name
prompt as expected.

Repeating the transcript below:

Shall I record this change? (111/120)  [ynWsfvpxdaqjk], or ? for help: a
...
Shall I record this change? (112/120)  [ynWsfvpxdaqjk], or ? for help: a

What is the patch name? Do you want to add a long comment? [yn]n
Finished recording patch 'a'

It's as if registered you hitting y 111 times but somehow displayed them wrong
so that in fact, you were answering 'y' to 111, 'a' to 112 and 'a' to the patch
name prompt.
msg8599 (view) Author: marcot Date: 2009-08-30.14:29:50
Hello Eric.

(...)
> Marco, do you still get the same symptoms Darcs 2.3?

I tried it here but I couldn't reproduce.  Maybe you should just close the bug,
and if I get to it once again I'll reopen it.

Greetings.
msg8601 (view) Author: kowey Date: 2009-08-30.14:49:46
Thanks Marco, I'll presumed-dead this and hope it never happens again!
History
Date User Action Args
2008-10-02 15:39:05marcotcreate
2009-01-26 01:33:44twbsetstatus: unread -> unknown
nosy: + twb
messages: + msg7196
2009-01-26 02:11:45twbsetstatus: unknown -> waiting-for
nosy: kowey, dagit, simon, twb, marcot, thorkilnaur, dmitry.kurochkin
2009-01-26 14:13:59marcotsetnosy: kowey, dagit, simon, twb, marcot, thorkilnaur, dmitry.kurochkin
messages: + msg7213
2009-02-16 23:45:33twbsetnosy: kowey, dagit, simon, twb, marcot, thorkilnaur, dmitry.kurochkin
messages: + msg7323
2009-08-10 23:47:11adminsetnosy: - dagit
2009-08-25 17:30:03adminsetnosy: + darcs-devel, - simon
2009-08-26 17:27:07koweysetnosy: kowey, darcs-devel, twb, marcot, thorkilnaur, dmitry.kurochkin
messages: + msg8519
assignedto: marcot
2009-08-27 14:33:33adminsetnosy: kowey, darcs-devel, twb, marcot, thorkilnaur, dmitry.kurochkin
2009-08-30 14:29:52marcotsetnosy: kowey, darcs-devel, twb, marcot, thorkilnaur, dmitry.kurochkin
messages: + msg8599
2009-08-30 14:49:48koweysetstatus: waiting-for -> given-up
nosy: kowey, darcs-devel, twb, marcot, thorkilnaur, dmitry.kurochkin
messages: + msg8601
assignedto: marcot ->