darcs

Issue 1189 lock is not deleted on ctrl-C

Title lock is not deleted on ctrl-C
Priority urgent Status resolved
Milestone Resolved in
Superseder Nosy List ckeen, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur
Assigned To
Topics Regression

Created on 2008-10-31.13:59:20 by droundy, last changed 2009-08-27.14:13:35 by admin.

Messages
msg6552 (view) Author: droundy Date: 2008-10-31.13:59:16
darcs no longer removes the _darcs/lock file when ctrl-C is hit while recording
(or doing just about anything else).  I could track this down, but I'd really
prefer to have a test for it first.  Alas, I've spent an hour or so trying to
construct such a test, but have failed.  :( Tricks like

sleep 10 | darcs record
kill %darcs

don't seem to work except interactively--which is not the point, it's easy
enough to reproduce this bug interactively.  Of course, this regression may
depend on stdin/out being a terminal, in which case it may not be possible to
check in the test suite.  :(

David
msg6598 (view) Author: ckeen Date: 2008-11-05.20:11:59
Interesting. I have reported this previously but now cannot reproduce this
anymore on my repos. Which repo version have you been using for this test? An
old one or a hashed repo? Maybe the difference is there?
msg6609 (view) Author: droundy Date: 2008-11-06.12:34:43
On Wed, Nov 05, 2008 at 08:12:01PM -0000, Christian Kellermann wrote:
> Interesting. I have reported this previously but now cannot reproduce this
> anymore on my repos. Which repo version have you been using for this test? An
> old one or a hashed repo? Maybe the difference is there?

The darcs repo.  Perhaps you're using haskeline? Or maybe it's the version
of ghc involved? It's broken for me when compiling darcs with either ghc
6.8.2 or ghc 6.6.
-- 
David Roundy
http://www.darcs.net
msg6675 (view) Author: ckeen Date: 2008-11-14.18:27:02
I am still unable to provoke this. I have seen a mail containing a patch for the
cabal build system but since we still have Makefiles we need to adress this
issue as well. Is this still an existing problem for you David?
msg6676 (view) Author: droundy Date: 2008-11-14.18:33:14
On Fri, Nov 14, 2008 at 06:27:05PM -0000, Christian Kellermann wrote:
> I am still unable to provoke this. I have seen a mail containing a patch for the
> cabal build system but since we still have Makefiles we need to adress this
> issue as well. Is this still an existing problem for you David?

No, my patch to franchise fixed the problem for me, and there never was an
issue with the makefile.

David
msg6681 (view) Author: kowey Date: 2008-11-15.14:28:14
Resolved, as pointed out by David and Christian.
History
Date User Action Args
2008-10-31 13:59:20droundycreate
2008-11-05 20:12:01ckeensetstatus: unread -> unknown
nosy: + ckeen
messages: + msg6598
2008-11-06 12:34:47droundysetnosy: droundy, kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg6609
2008-11-14 18:27:05ckeensetnosy: droundy, kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg6675
2008-11-14 18:33:16droundysetnosy: droundy, kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg6676
2008-11-15 14:28:16koweysetstatus: unknown -> resolved
nosy: droundy, kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg6681
2009-08-06 18:01:39adminsetnosy: + markstos, jast, Serware, darcs-devel, zooko, mornfall, tommy, beschmi, - droundy, ckeen
2009-08-06 21:13:59adminsetnosy: - beschmi
2009-08-10 21:50:36adminsetnosy: + ckeen, - tommy, markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:50:06adminsetnosy: - dagit
2009-08-25 17:33:11adminsetnosy: + darcs-devel, - simon
2009-08-27 14:13:35adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, ckeen