darcs

Issue 1191 Fix for issue 571 is missing from configure.ac

Title Fix for issue 571 is missing from configure.ac
Priority bug Status wont-fix
Milestone Resolved in
Superseder Nosy List Serware, darcs-devel, dmitry.kurochkin, dwc, jaredj, kowey, thorkilnaur, twb
Assigned To
Topics ProbablyEasy, Regression, SunOS

Created on 2008-11-03.04:00:57 by dwc, last changed 2009-10-23.23:31:00 by admin.

Messages
msg6565 (view) Author: dwc Date: 2008-11-03.04:00:47
Changeset 4829 at http://allmydata.org/trac/darcs-2/changeset/4829/ added a
check for termio.h.  Sometime since then (I haven't determined when), the stanza
was removed, (I checked current) which breaks the build on Solaris machines.  I
am using the 2.1.0 release tarball.

While checking my build configuration, I also noticed that the following are
also undefined in autoconf.mk -- @USE_GNULIBSHA1@ @HAVE_LIBCURL@ @HAVE_LIBWWW@
@WXFLAGS@, even though libcurl 7.19.0 was found.
msg7042 (view) Author: twb Date: 2009-01-11.15:29:27
It looks like David erroneously removed the check from configure.ac

  $ darcs cha -v -p 'termio\.h'
  Fri Apr 18 03:24:27 EST 2008  David Roundy <droundy@darcs.net>
    * remove unneeded check for termio.h.
      hunk ./configure.ac 496
      -  AC_CHECK_HEADERS([termio.h], [HAVE_TERMIO_H=True]) dnl see External.hs
      hunk ./configure.ac 501
      -AC_SUBST(HAVE_TERMIO_H)

Note that HAVE_TERMIO_H is still used in autoconf.mk and GNUmakefile,
so the above patch was a bit hokey.

But Darcs won't let me just roll back that change, because it has
dependencies.

  $ darcs rollback -p 'termio\.h'
  No patches selected!

If you add these lines back into configure.ac, does Darcs work again
for you on Solaris?
msg8095 (view) Author: kowey Date: 2009-08-11.16:18:03
dwc: Hi, I suspect that our switching to a new build system (cabal) has fixed
something like this along the way.  It'd be great if you could try out Darcs 2.3
and let us know if you run into any more trouble.  Thanks!
History
Date User Action Args
2008-11-03 04:00:57dwccreate
2009-01-11 15:29:31twbsetstatus: unread -> unknown
nosy: + twb
messages: + msg7042
2009-08-10 23:50:10adminsetnosy: - dagit
2009-08-11 16:18:13koweysetstatus: unknown -> wont-fix
nosy: kowey, simon, twb, thorkilnaur, jaredj, dmitry.kurochkin, Serware, dwc
topic: - Darcs2
messages: + msg8095
2009-08-25 17:33:17adminsetnosy: + darcs-devel, - simon
2009-08-27 14:22:59adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, jaredj, dmitry.kurochkin, Serware, dwc
2009-10-23 22:45:26adminsetnosy: + serware, - Serware
2009-10-23 23:31:00adminsetnosy: + Serware, - serware