darcs

Issue 1219 --external-merge with deletion

Title --external-merge with deletion
Priority bug Status duplicate
Milestone Resolved in
Superseder --external-merge tool should properly reference renamed files
View: 189
Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, twb
Assigned To
Topics

Created on 2008-11-11.02:46:55 by twb, last changed 2009-09-04.17:24:14 by kowey.

Files
File name Uploaded Type Edit Remove
tmp.sh twb, 2008-11-14.00:48:34 application/x-sh
typescript twb, 2008-11-14.00:48:34 text/plain
Messages
msg6647 (view) Author: twb Date: 2008-11-11.02:46:52
Just now I pulled in a recent unstable patch, which deleted the
Franchise Setup.hs file.  In the repo was already a draft patch that
*MOVED* it to release/.

Merging file ./Setup.hs by hand.
Running command 'twb-meld-darcs /tmp/merged/./Setup.hs /tmp/ancestor/./release/Setup-franchise.hs /tmp/version1/./release/Setup-franchise.hs /tmp/version2/./release/Setup-franchise.hs'

This didn't do what I want, because the ancestor/ and version2/ files
did not exist.
msg6671 (view) Author: twb Date: 2008-11-14.00:48:35
Attached is a test case that demonstrates the problem.

It seems that the output of ls is being hidden by Darcs.  By changing
"ls" to "xterm -hold -e ls", you can see the output, which is:

    ls: cannot access /tmp/ancestor/./y: No such file or directory
    ls: cannot access /tmp/version2/./y: No such file or directory
    -rw-r--r-- 1 twb twb 4 2008-11-14 11:47 /tmp/version1/./y
Attachments
msg6850 (view) Author: kowey Date: 2008-12-21.17:24:42
What would be the ideal behaviour here?
msg6855 (view) Author: twb Date: 2008-12-21.23:37:33
On Sun, Dec 21, 2008 at 05:24:44PM -0000, Eric Kow wrote:
> What would be the ideal behaviour here?

If I rightly remember which bug we're talking about, the problem is
that external merge was called on

    %1/bar %2/bar %a/bar %o/bar

But in %1 and %a, foo has not been renamed to bar.  So it should be
calling

    %1/foo %2/bar %a/foo %o/bar
msg6856 (view) Author: twb Date: 2008-12-21.23:38:51
On Thu, Nov 13, 2008 at 01:48:35PM +0000, trentbuck@gmail.com wrote:
> Attached is a test case that demonstrates the problem.
> 
> It seems that the output of ls is being hidden by Darcs.  By changing
> "ls" to "xterm -hold -e ls", you can see the output, which is:
> 
>     ls: cannot access /tmp/ancestor/./y: No such file or directory
>     ls: cannot access /tmp/version2/./y: No such file or directory
>     -rw-r--r-- 1 twb twb 4 2008-11-14 11:47 /tmp/version1/./y

Sorry, I think this message was for a different bug, but I don't know
which one yet.
msg8688 (view) Author: kowey Date: 2009-09-04.17:24:12
Unless I'm mistaken, this is another instance of issue189.  It might not be if 
the *deletion* was important and not the renaming here.
History
Date User Action Args
2008-11-11 02:46:55twbcreate
2008-11-14 00:48:37twbsetfiles: + tmp.sh, typescript
nosy: kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin
status: unread -> unknown
messages: + msg6671
2008-12-21 17:24:44koweysetpriority: bug
status: unknown -> waiting-for
messages: + msg6850
nosy: kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin
2008-12-21 23:37:36twbsetnosy: kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin
messages: + msg6855
2008-12-21 23:38:54twbsetnosy: kowey, dagit, simon, twb, thorkilnaur, dmitry.kurochkin
messages: + msg6856
2009-08-10 23:51:16adminsetnosy: - dagit
2009-08-25 17:34:15adminsetnosy: + darcs-devel, - simon
2009-08-27 14:14:03adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin
2009-09-04 17:24:14koweysetstatus: waiting-for -> duplicate
nosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin
superseder: + --external-merge tool should properly reference renamed files
messages: + msg8688
title: External merge with deletion -> --external-merge with deletion