darcs

Issue 1230 darcs changes segfaults when piped to a pager

Title darcs changes segfaults when piped to a pager
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List ckeen, darcs-devel, dmitry.kurochkin, kowey, thorkilnaur
Assigned To
Topics

Created on 2008-11-14.18:57:31 by ckeen, last changed 2009-08-27.14:26:18 by admin.

Messages
msg6677 (view) Author: ckeen Date: 2008-11-14.18:57:28
When I run darcs changes |less on OpenBSD darcs segfaults.

A test case is:

darcs init
echo 1 > 1
darcs add 1
darcs record -am 'a commit' 1
darcs changes | echo # this causes darcs writing to a pipe that's not existing

Another test case is the darcs repo. Important here is that the pager has to
block the pipe, because it filles more than one screen.

A gdb stacktrace looks like this:

gdb> bt
#0  0x1c3c7c42 in deRefStablePtrzh_fast ()
#1  0x00000000 in ?? ()

which is not really helpful...
msg7653 (view) Author: kowey Date: 2009-04-09.16:13:14
Christian (not Christoph although you can probably count on me making this
mistake again): is this something that can be caught by a test case?
msg7657 (view) Author: ckeen Date: 2009-04-09.18:07:18
I can surely make a test case out of it. It turns out that this problem has gone
by now. I have not checked which patch is responsible for it though.

Shall I?
msg7658 (view) Author: kowey Date: 2009-04-09.18:11:27
The ideal would be to create a test case, show that it fails on an older version
of darcs (without caring about which patch fixes it) so that we know the test is
actually doing something, and also show that it succeeds, which tells us it
won't happen again.

Thanks!
msg8232 (view) Author: kowey Date: 2009-08-18.09:29:22
I think we can just resolve this.
History
Date User Action Args
2008-11-14 18:57:31ckeencreate
2009-04-09 16:13:16koweysetstatus: unread -> unknown
nosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg7653
2009-04-09 18:07:21ckeensetnosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg7657
2009-04-09 18:11:30koweysetnosy: kowey, dagit, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg7658
2009-08-10 23:51:47adminsetnosy: - dagit
2009-08-18 09:29:23koweysetstatus: unknown -> resolved
nosy: kowey, simon, thorkilnaur, dmitry.kurochkin, ckeen
messages: + msg8232
2009-08-25 17:34:36adminsetnosy: + darcs-devel, - simon
2009-08-27 14:26:18adminsetnosy: kowey, darcs-devel, thorkilnaur, dmitry.kurochkin, ckeen