darcs

Issue 128 apply_list fails on some hunks

Title apply_list fails on some hunks
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy
Assigned To
Topics

Created on 2006-02-08.00:30:00 by tommy, last changed 2009-08-27.13:46:33 by admin.

Messages
msg475 (view) Author: tommy Date: 2006-02-08.00:29:59
From: Aaron Kaplan
There seems to be a bug in the way darcs inverts certain patches.
Consider a file that begins as

  ---8<-----
  one
  two
  three
  ---8<-----

and then is modified to look like

  ---8<-----
  three
  one
  ---8<-----

If you record this change and then unpull it, the file ends up like
this:

  ---8<-----
  three

  one
  ---8<-----

From: Tommy Pettersson
I have narrowed down where this bug happens.  It is in the
optimization of apply_list in PatchApply.lhs.
msg511 (view) Author: tommy Date: 2006-02-28.11:28:07
fixed in 1.0.6
Fri Jan 20 00:15:23 CET 2006  Tommy Pettersson <ptp@lysator.liu.se>
  * revert optimization for apply_list
  The optimization made unrecord and unpull sometimes fail.
  It, unnecessarily, removes the --set-script-executable functionality.
History
Date User Action Args
2006-02-08 00:30:00tommycreate
2006-02-28 11:28:07tommysetstatus: unread -> resolved
messages: + msg511
2009-08-06 17:41:10adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, kowey, beschmi, thorkilnaur, - droundy
2009-08-06 20:48:56adminsetnosy: - beschmi
2009-08-10 21:50:50adminsetnosy: - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:54:43adminsetnosy: + darcs-devel, - simon
2009-08-27 13:46:33adminsetnosy: tommy, kowey, darcs-devel, thorkilnaur, dmitry.kurochkin