darcs

Issue 1309 roundup: don't set 'nosy' on *every* update

Title roundup: don't set 'nosy' on *every* update
Priority wishlist Status resolved
Milestone Resolved in
Superseder Nosy List Serware, darcs-devel, dmitry.kurochkin, kowey, twb
Assigned To
Topics BugTracker

Created on 2009-01-11.11:22:07 by twb, last changed 2009-10-25.09:34:58 by kowey.

Messages
msg7035 (view) Author: twb Date: 2009-01-11.11:22:02
>From the property journal of issue1284:

  2009-01-06 00:29:32 twb set nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
                              messages: + msg6995
  2009-01-11 10:40:11 twb set assignedto: twb ->
                              nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
  2009-01-11 10:51:50 twb set topic: + ProbablyEasy
                              nosy: + jaredj
  2009-01-11 11:17:24 twb set nosy: kowey, simon, twb, thorkilnaur, jaredj, dmitry.kurochkin
                              messages: + msg7034

These properties were changed by simple bodyless messages like
"[assignedto=]".  *I'm* not setting nosy, and repeatedly setting nosy
to the same thing bloats out the property journal and makes it hard to
read.

I guess what's happening is that someone added a hook to set nosy when
a ticket is changed by email, to make sure that when a ticket is first
created, the core team are in the nosy list.  But I guess it's
accidentally being called EVERY time an issue is changed via email.
msg7457 (view) Author: thorkilnaur Date: 2009-03-14.20:53:56
Thank you. As I understand this, you wish for Roundup to leave out the messages 
that state that the nosy list has been set when it, in fact, hasn't changed. In 
the example you quote, "nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin" 
for "2009-01-11 10:40:11" and "nosy: kowey, simon, twb, thorkilnaur, jaredj, 
dmitry.kurochkin" for "2009-01-11 11:17:24" should not be included in the history.

It is not clear to me whether this is a problem in Roundup or the way the darcs 
tracker is configured or possibly both. I have looked at the Roundup documentation 
(http://roundup.sourceforge.net/doc-1.0/) and the repository at 
http://darcs.net/darcsbugtracker (which I believe contains the darcs tracker 
configuration) without coming closer to an answer to this question. My best guess 
is that Roundup is careless, in some cases, and not properly detecting that a 
wholesale replacement of the nosy list for an issue is not actually changing 
anything.

Is anyone able to shed some light on this question?

Thanks and best regarads
Thorkil
msg7464 (view) Author: kowey Date: 2009-03-15.13:27:10
Hi Simon,

Is this something you could shed light on?

Thanks!
msg8254 (view) Author: kowey Date: 2009-08-18.15:08:41
Sounds like we need to ask somebody on the roundup mailing list.
msg9022 (view) Author: kowey Date: 2009-10-25.08:48:06
Note that this also happens with the web interface too, and it doesn't affect
the Python instance of Roundup (eg. http://bugs.python.org/issue1602 ), so it's
either something to do with our version of roundup or more probably, our setup.
msg9023 (view) Author: kowey Date: 2009-10-25.09:34:55
Hurrah, one more roundup issue fixed.

This was due to a our nosy_keyword_reaction detector (plugin) systematically
updating nosy.  I've pushed some patches so that it only updates nosy when nosy
actually changes, following the model of the nosyreaction detector.  

I'm also in the middle of checking out the roundup SVN depot in case they'd like
a patch.
History
Date User Action Args
2009-01-11 11:22:07twbcreate
2009-03-14 20:53:59thorkilnaursetpriority: wishlist
nosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
status: unread -> unknown
messages: + msg7457
2009-03-15 13:27:12koweysetnosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin
messages: + msg7464
assignedto: simon
2009-08-18 15:08:44koweysetstatus: unknown -> needs-reproduction
nosy: + Serware
topic: + BugTracker
messages: + msg8254
assignedto: simon -> (no value)
2009-08-25 17:38:34adminsetnosy: + darcs-devel, - simon
2009-08-27 14:27:04adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin, Serware
2009-10-22 14:24:38koweysetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin, Serware
messages: + msg9005
2009-10-22 14:28:07koweysetnosy: kowey, darcs-devel, twb, thorkilnaur, dmitry.kurochkin, Serware
messages: + msg9006
2009-10-22 14:30:06koweysetnosy: - thorkilnaur
messages: + msg9007
2009-10-22 14:33:09koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 14:33:32koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 14:38:36koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 14:39:26koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 14:44:39koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 14:48:21koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 14:48:48koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 15:01:33koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-22 15:01:57koweysetnosy: - kowey
2009-10-23 22:46:25adminsetnosy: + serware, - Serware
2009-10-23 23:31:53adminsetnosy: + Serware, - serware
2009-10-25 08:48:08koweysetnosy: + kowey
messages: + msg9022
title: roundup: don't set 'nosy' on *every* email -> roundup: don't set 'nosy' on *every* update
2009-10-25 08:49:29koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
messages: - msg9005
2009-10-25 08:49:42koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
messages: - msg9007
2009-10-25 08:49:51koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
messages: - msg9006
2009-10-25 08:54:46koweysetnosy: - kowey
2009-10-25 09:00:45koweysetassignedto: kowey
nosy: + kowey
2009-10-25 09:00:57koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:01:26koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:03:21koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:07:25koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:25:16koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:25:27koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:28:25koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:29:37koweysetnosy: kowey, darcs-devel, twb, dmitry.kurochkin, Serware
2009-10-25 09:34:58koweysetstatus: needs-reproduction -> resolved
assignedto: kowey ->
messages: + msg9023