I have tried the following with both --old-fashioned-inventory and
--darcs-2, and both list files in _darcs/patches/pending that darcs
thinks should be added, when in fact, I just deleted them and removed
them from the only patch that knew about them.

darcs init --darcs-2
mkdir a
mkdir b
touch a/1
touch a/2
touch b/3
touch b/4
darcs add -r a
darcs add -r b
darcs record -m 'initial' --all --author testing
cat _darcs/patches/pending
rm -rf b
echo y | darcs amend-record -m 'initial' --all
cat _darcs/patches/pending
echo 'why are this directory and its files listed in pending?'

I was using darcs 2.2.pre2.  I have not checked the current release
candidate.

I came across this because I accidentally added a directory that I did
not want to track in a repository.  I immediately amend-recorded the
patch, and was amazed to see that 'darcs whatsnew -s' said that I had
added the directory and files that I had just deleted.

-kolibrie

Is the behaviour you are expecting for darcs to detect that the file (in
pending) is no longer in the working directory?  That sounds reasonable to me.  

Could you submit a test case?
See http://wiki.darcs.net/index.html/RegressionTests for details

Hi Nathan,

For what it's worth, I don't think the repository format makes a difference here.  

I've been looking into this a bit (see also issue1325) and have managed to boil
down your example to just the directory.  Does the attached test capture the bug
to your satisfaction?

I'm wondering also if one could make a case that this behaviour would be
desirable.  I don't think so, though...

Attachments

• failing-issue1316.sh

Hi Nathan, do you have a moment to try the test attached to this tracker
and let me know if captures the essence of your bug?  Thanks!

I'm going to assume that my test (which I've submitted to Darcs) boils 
down Nathan's one correctly, moreover that this should be considered a 
bug.  Interesting

resolved by

patch ffa25a85a94ebb4ec8ac856fdb33135387cb34e4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jul  2 15:40:08 CEST 2018
  * fix handling of pending patch in amend command