darcs

Issue 1444 pass command line file/directory arguments to prehook

Title pass command line file/directory arguments to prehook
Priority feature Status given-up
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, jaredj, kolmodin, kowey, thorkilnaur, twb
Assigned To
Topics ProbablyEasy

Created on 2009-04-17.16:01:58 by kolmodin, last changed 2017-07-30.22:56:47 by gh.

Messages
msg7714 (view) Author: kolmodin Date: 2009-04-17.16:01:53
Suppose I run

$ cd myrepo/sub
$ darcs record foo/ bar/ baz.txt

The pre-hook will be executed in the root of the darcs repo.
I'd like to have the search path that the user told darcs to use to find changed
files, to be in an environment variable when running the pre-hook.

DARCS_BLAH="sub/foo sub/bar sub/baz.txt"

The paths are normalized, so that the are relative to the root of the repository.

This would be useful for a QA enforcer in the gentoo overlay.
Knowing the changed files is similar, but knowing what the user asked for is ideal.
msg7717 (view) Author: twb Date: 2009-04-18.03:49:54
On Fri, Apr 17, 2009 at 06:01:53AM +0000, Lennart Kolmodin wrote:
> The pre-hook will be executed in the root of the darcs repo.  I'd
> like to have the search path that the user told darcs to use to find
> changed files, to be in an environment variable when running the
> pre-hook.
>
> DARCS_BLAH="sub/foo sub/bar sub/baz.txt"

Darcs already passes several data via environment variables.  Can
someone confirm that this is not already among them?
msg7718 (view) Author: kowey Date: 2009-04-18.08:28:06
On Sat, Apr 18, 2009 at 03:49:56 -0000, Trent Buck wrote:
> > DARCS_BLAH="sub/foo sub/bar sub/baz.txt"
> 
> Darcs already passes several data via environment variables.  Can
> someone confirm that this is not already among them?

I think the issue is that these are passed in for the posthooks, and
unfortunately it's not self-evident how to do the same for prehooks.
(the posthook code is based on the patch contents)
msg8379 (view) Author: kowey Date: 2009-08-23.10:01:33
This sounds like it shouldn't be too hard to do.

I might avoid calling it DARCS_FILES (which is what we use for the posthooks)
because this means something subtly different.  DARCS_FILES is based on the
patch contents.

What we want here is something more like DARCS_FILE_ARGS.

Things to watch out for is the path normalisation and also --repodir.
History
Date User Action Args
2009-04-17 16:01:58kolmodincreate
2009-04-18 03:48:16twbsetnosy: kowey, simon, thorkilnaur, dmitry.kurochkin, kolmodin
title: Pass the user specificed record files/directories to prehook -> Pass the user specified record files/directories to prehook
2009-04-18 03:49:56twbsetstatus: unread -> unknown
nosy: + twb
messages: + msg7717
2009-04-18 08:28:09koweysetnosy: kowey, simon, twb, thorkilnaur, dmitry.kurochkin, kolmodin
messages: + msg7718
2009-08-23 10:01:37koweysetstatus: unknown -> needs-implementation
nosy: + jaredj
topic: + ProbablyEasy
messages: + msg8379
title: Pass the user specified record files/directories to prehook -> pass command line file/directory arguments to prehook
2009-08-25 17:43:47adminsetnosy: + darcs-devel, - simon
2009-08-27 14:30:12adminsetnosy: kowey, darcs-devel, twb, thorkilnaur, jaredj, dmitry.kurochkin, kolmodin
2017-07-30 22:56:47ghsetstatus: needs-implementation -> given-up