darcs

Issue 1479 Memory leak with amend --edit

Title Memory leak with amend --edit
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, marcot, thorkilnaur, tux_rocker
Assigned To
Topics Performance

Created on 2009-06-10.22:54:54 by marcot, last changed 2009-08-27.14:21:25 by admin.

Messages
msg7909 (view) Author: marcot Date: 2009-06-10.22:54:50
Hello,

I've downloaded the ghc darcs repository, and made the following patch:

    hunk ./README 55
    -  This grabs the "boot" packages by default.  To get the full set
of
    -  packages, instead say
    -
    -     $ ./darcs-all --extra get
    -
    -  This also downloads the libraries that are normally bundled in
the
    -  "extralibs" package (see above).
    -

I recorded it with darcs record, and then tried to edit it with darcs
amend --edit.

After editing, I got:

Wed Jun 10 19:23:58 BRT 2009  Marco T\c3\balio Gontijo e Silva <marcot@holoscopio.com>
  * README: Remove ./darcs-all --extra indication.
Shall I amend this patch? [yNvpxq], or ? for help: y
Waiting for Emacs...
Optimizing inventory 70200
Morto
.
.
.
marcot@zezinho:~/codigo/haskell/ghc$ darcs amend --edit
Wed Jun 10 19:23:58 BRT 2009  Marco T\c3\balio Gontijo e Silva <marcot@holoscopio.com>
  * README: Remove ./darcs-all --extra indication.
Shall I amend this patch? [yNvpxq], or ? for help: y
Waiting for Emacs...
Stack space overflow: current size 8388608 bytes.
Use `+RTS -Ksize' to increase it.
^C^C^C^C^C^C^C^C^C^C^C^@Morto

Morto means killed in pt_BR.

The first time it consumed all my 3GiB of RAM and after I pressed C-M-F1
to get to tty1 it took a while before I could killall -9 darcs.

In the second try I tried pressing C-c to stop it, but I couldn't, and I
had to go to tty1 again to kill it.

Greetings.
msg8028 (view) Author: kowey Date: 2009-08-06.14:15:18
Marco: can you reproduce this?

If so, is the --edit flag relevant at all? (I'm guessing not, but if you could
check, that'd be great)

Furthermore, what happens if you unrecord and then record, instead of amending?
msg8045 (view) Author: marcot Date: 2009-08-07.12:19:00
No, I can't reproduce it in the darcs version of darcs.

Greetings.
History
Date User Action Args
2009-06-10 22:54:54marcotcreate
2009-06-11 09:57:54tux_rockersetnosy: + tux_rocker
2009-08-06 14:15:22koweysetpriority: bug
nosy: kowey, simon, marcot, thorkilnaur, tux_rocker, dmitry.kurochkin
topic: + Performance
status: unread -> unknown
messages: + msg8028
2009-08-07 12:19:07marcotsetstatus: unknown -> resolved
nosy: kowey, simon, marcot, thorkilnaur, tux_rocker, dmitry.kurochkin
messages: + msg8045
2009-08-25 17:45:39adminsetnosy: + darcs-devel, - simon
2009-08-27 14:21:25adminsetnosy: kowey, darcs-devel, marcot, thorkilnaur, tux_rocker, dmitry.kurochkin