darcs

Issue 1596 dropped content from messages to bug tracker

Title dropped content from messages to bug tracker
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List Serware, WorldMaker, darcs-devel, dmitry.kurochkin, kowey, mornfall
Assigned To
Topics BugTracker

Created on 2009-09-03.06:52:30 by kowey, last changed 2009-10-24.00:00:25 by admin.

Messages
msg8665 (view) Author: kowey Date: 2009-09-03.06:52:26
I tried to sent a reply to the tracker (msg8663).  My message had these lines
in it, Minus the vertical-bar quoting

| Note that there is a commented-out                                                                           
| >  friendly_d d = calendarTimeToString . readPatchDate . d                                                   
| which appears to be wrong    

But the first two lines of that were silently removed.

The good news is that it appears to happen systematically:
I am now including this text:
| -----------------------8<---------------------------------
| Note that there is a commented-out                                                                           
| >  friendly_d d = calendarTimeToString . readPatchDate . d                                                   
| -----------------------8<---------------------------------
in my message, but I predict you'll only see the scissor marks.

Here we go!

-----------------------8<---------------------------------
Note that there is a commented-out                                                                           
>  friendly_d d = calendarTimeToString . readPatchDate . d                                                   
-----------------------8<---------------------------------
msg8666 (view) Author: kowey Date: 2009-09-03.06:57:48
On Thu, Sep 03, 2009 at 06:52:30 +0000, Eric Kow wrote:
> -----------------------8<---------------------------------
> Note that there is a commented-out                                                                           
> >  friendly_d d = calendarTimeToString . readPatchDate . d                                                   
> -----------------------8<---------------------------------

Huh? What gives? Now it doesn't want to delete my lines?

Try again:

Or even further into                                                                                         

  friendly_d :: B.ByteString -> String                                                                       
  friendly_d = calendarTimeToString . readPatchDate                                                          

which appears to be wrong
msg8667 (view) Author: WorldMaker Date: 2009-09-03.07:40:06
Eric Kow wrote:
> Eric Kow <kowey@darcs.net> added the comment:
> 
> On Thu, Sep 03, 2009 at 06:52:30 +0000, Eric Kow wrote:
>> -----------------------8<---------------------------------
>> Note that there is a commented-out                                                                           
>>>  friendly_d d = calendarTimeToString . readPatchDate . d                                                   
>> -----------------------8<---------------------------------
> 
> Huh? What gives? Now it doesn't want to delete my lines?

Some sort of quotation "alignment" issue? Does roundup try to keep spam 
out by cutting quotation lines that don't exist in previous messages? (I 
note this because one line there begins with the email quote marker '>'.)
msg8668 (view) Author: kowey Date: 2009-09-03.15:01:34
On Thu, Sep 03, 2009 at 03:37:30 -0400, Max Battcher wrote:
> Some sort of quotation "alignment" issue? Does roundup try to keep spam  
> out by cutting quotation lines that don't exist in previous messages? (I  
> note this because one line there begins with the email quote marker '>'.)

Blah

Let's see what happens.
msg8669 (view) Author: kowey Date: 2009-09-03.15:14:35
On Thu, Sep 03, 2009 at 15:01:38 +0000, Eric Kow wrote:
> > Some sort of quotation "alignment" issue? Does roundup try to keep spam  
> > out by cutting quotation lines that don't exist in previous messages? (I  
> > note this because one line there begins with the email quote marker '>'.)
> 
> Blah

Yes! Max's diagnosis appears to be correct; quotation lines that don't
appear in any other message get cut.  So this works:
> > out by cutting quotation lines that don't exist in previous messages? (I  

But this probably does not:
> > by cutting quotation lines that don't exist in previous messages? (I  

Hmm, I think can see why this feature exists, but I'm not sure if it's
actually a good idea.

I think we need somebody to find out which component of roundup
is doing this and if it's something we can configure.

I'm happy with not fixing it, as I guess this only very rarely bites
people.
msg8737 (view) Author: kowey Date: 2009-09-07.12:59:25
I believe msg8734 is a case of Petr getting bitten by this bug.
Petr: did the missing lines start with quotation marks, for example?\

I think our current roundup configuration is set to remove quotes that roundup
did not see in any of the messages, and I think it does this to avoid repeating
signatures and other random crap.

We need somebody to look into disabling that feature because while it does keep
things nice and clean it also causes mystery content loss, which is a greater evil.
msg8738 (view) Author: kowey Date: 2009-09-07.13:00:26
This is a test submission from the web form using a non-existent quote.

Non-existent quote below:
> yargh
End non-existent quote

(Was > yargh)
msg8739 (view) Author: kowey Date: 2009-09-07.13:02:23
OK hypothesis disproven.  Roundup is perfectly happy to leave behind my fake
quoted text from the web form (which makes sense; people don't add random crap
to via the web form)
msg8981 (view) Author: mornfall Date: 2009-10-21.17:33:39
So it will lose lines starting with --?
-- like this?
Or maybe everything after --?
--
like this?
msg8982 (view) Author: mornfall Date: 2009-10-21.17:35:58
No. I guess this is pretty random then, since this happened twice to me already
and it's really annoying. Just one other try, with --
at the end of a line.
msg9001 (view) Author: kowey Date: 2009-10-22.13:42:19
Testing a leave_body_unchanged setting for email content.
> soatuheasethuaeruchacautam.

It's a bit regrettable that we have to set this as the bug-tracker
gets a bit noisier, but that's way better than dropped content.

Note that if this works, we will still have issue1653 to contend
with.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg9002 (view) Author: kowey Date: 2009-10-22.13:46:35
Fixed by the 'leave_body_unchanged' setting suggested by ThomasAH from #roundup
(thanks!).
History
Date User Action Args
2009-09-03 06:52:30koweycreate
2009-09-03 06:57:50koweysetnosy: kowey, darcs-devel, dmitry.kurochkin
messages: + msg8666
2009-09-03 07:40:09WorldMakersetnosy: + WorldMaker
messages: + msg8667
2009-09-03 15:01:38koweysetnosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin
messages: + msg8668
2009-09-03 15:14:37koweysetstatus: unknown -> needs-reproduction
nosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin
messages: + msg8669
2009-09-04 08:28:46koweysetpriority: bug
nosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin
2009-09-07 11:52:54koweysettopic: + BugTracker
nosy: + Serware
2009-09-07 12:59:27koweysetnosy: + mornfall
messages: + msg8737
2009-09-07 13:00:28koweysetnosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin, Serware, mornfall
messages: + msg8738
2009-09-07 13:02:25koweysetnosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin, Serware, mornfall
messages: + msg8739
2009-10-21 17:33:41mornfallsetnosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin, Serware, mornfall
messages: + msg8981
2009-10-21 17:36:02mornfallsetnosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin, Serware, mornfall
messages: + msg8982
2009-10-22 13:42:22koweysetnosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin, Serware, mornfall
messages: + msg9001
2009-10-22 13:46:37koweysetstatus: needs-reproduction -> resolved
nosy: kowey, darcs-devel, WorldMaker, dmitry.kurochkin, Serware, mornfall
messages: + msg9002
2009-10-23 22:39:02adminsetnosy: + maxbattcher, - WorldMaker
2009-10-23 22:46:08adminsetnosy: + serware, - Serware
2009-10-23 23:31:41adminsetnosy: + Serware, - serware
2009-10-24 00:00:25adminsetnosy: + WorldMaker, - maxbattcher