2009/11/8 Jason Dagit <dagitj@gmail.com>

>
>
> On Sun, Nov 1, 2009 at 3:46 PM, Eric Kow <bugs@darcs.net> wrote:
>
>>
>> Eric Kow <kowey@darcs.net> added the comment:
>>
>> Hi Jason, the first patch here has been reviewed.  The second patch is
>> just a
>> camel casing which I think you can review in your sleep.  Perhaps the
>> perfect
>> patch for busy Jasons?
>>
>
> The weird thing is this patch are these lines:
> -write_default_prefs = do set_preflist "boring" default_boring
> +write_default_prefs =   do set_preflist "boring" default_boring
>
> -get_preflist p = do prefs <- prefsDirectory `mplus` return "x"
> +get_preflist p =  do prefs <- prefsDirectory `mplus` return "x"
>
> -set_prefval p v = do pl <- get_preflist "prefs"
> +set_prefval p v =  do pl <- get_preflist "prefs"
>
> Any reason for the whitespace changes?
>
> I'm applying the patch anyway, but I just wondered.
>

There may have been issues applying this:

Sat Oct 31 13:21:37 PDT 2009  Eric Kow <kowey@darcs.net>
  * Camel-case functions exported by Darcs.Repository.Prefs (and some more).
Shall I push this patch? (1/1)  [ynWvplxdaqjk], or ? for help: y
Enter passphrase for key '':
Writing inventory 20/59
Configuring darcs-2.3.1...
Setup: At least the following dependencies are missing:
hashed-storage >=0.4.1 && <0.5 && >=0.4.1 && <0.5

Looks like someone needs to update hashed-storage on the server.

Jason

Attachments

• unnamed

Thanks for pointing this out, Jason.  I've logged in, cabal updated and cabal
installed hashed-storage (which anybody on the review team can do, hint hint :-D).

BTW, Looks like the tracker got confused by the [patch=32, status=accepted]
syntax, so this got created as a bug.  Oh well.