darcs

Issue 1751 issue tracker creates messages with msg-id same as in-reply-to

Title issue tracker creates messages with msg-id same as in-reply-to
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List Serware, darcs-devel, dmitry.kurochkin, ertai, kowey
Assigned To
Topics BugTracker

Created on 2010-02-22.14:26:18 by kowey, last changed 2010-03-21.14:48:55 by kowey.

Messages
msg10061 (view) Author: kowey Date: 2010-02-22.14:26:13
This needs investigation.

You can see this by looking at the header for any patch message. 
Interestingly, this does not affect the issue tracker messages.
msg10062 (view) Author: kowey Date: 2010-02-22.14:29:46
Oh! msg10061 from this bug also seems to exhibit this symptom and
perhaps this reply will as well.
msg10063 (view) Author: kowey Date: 2010-02-22.14:41:22
OK, I have a better idea what's happening.  The second message has a
correct in-reply-to.

Notice this chunk of roundupdb.py:

            if not inreplyto:
                # Default the reply to the first message
                msgs = self.get(nodeid, 'messages')
                # Assume messages are sorted by increasing message
number here
                if msgs[0] != nodeid:
                    inreplyto = messages.get(msgs[0], 'messageid')
                    if inreplyto:
                        writer.addheader('In-Reply-To', inreplyto)

I'm not clear on why it does this.  Why not just not write the header?
Anyway, I've filed http://issues.roundup-tracker.org/issue2550640 and
will follow up when they reply.

PS. trying new policy trick of assigning to the person who's supposed to
chase up, if we're actually waiting-for an outside party.  In this case,
we're waiting for the Roundup Team, but I'm assigning to me as I'm the
one that gets replies on their ticket.
msg10064 (view) Author: kowey Date: 2010-02-23.08:48:15
The roundup folks got back to us very quickly.  Turns out it was a bug,
and they've fixed it.  This looks like just a one-liner
http://svn.roundup-tracker.org/viewvc/roundup/roundup/trunk/roundup/roundupdb.py?r1=4464&r2=4463&pathrev=4464
(if you ignore what should have been a darcs replace patch for them), so
maybe we should just fix it on our install.
msg10391 (view) Author: kowey Date: 2010-03-21.14:48:53
This was resolved by changing this snippet

-               if msgs[0] != nodeid:
+               if msgs[0] != msgid:
                    inreplyto = messages.get(msgs[0], 'messageid')

You can check issue1799 and issue1799 to confirm this.
History
Date User Action Args
2010-02-22 14:26:18koweycreate
2010-02-22 14:29:48koweysetmessages: + msg10062
title: patch tracker creates messages with msg-id same as in-reply-to -> issue tracker creates messages with msg-id same as in-reply-to
2010-02-22 14:41:25koweysetstatus: needs-reproduction -> waiting-for
assignedto: kowey
messages: + msg10063
2010-02-23 08:48:20koweysetstatus: waiting-for -> needs-reproduction
messages: + msg10064
2010-03-21 14:48:55koweysetstatus: needs-reproduction -> resolved
assignedto: kowey ->
messages: + msg10391