darcs

Issue 1754 failure in issue458 test under selinux

Title failure in issue458 test under selinux
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, jaredj, juhp, kowey, markstos, thorkilnaur, tommy
Assigned To juhp
Topics Devel

Created on 2010-03-01.11:13:42 by admin, last changed 2010-03-22.04:48:42 by juhp.

Messages
msg10087 (view) Author: juhp Date: 2010-03-01.06:39:05
With selinux, ls outputs "-rwx------." rather than "-rwx------" making 
this test fail.

Better to use grep than diff here I think.

Is it better to reopen, create a bug, or ?

This patch works for me on fedora 12:

--- darcs-2.4/tests/issue458.sh~	2010-02-27 04:10:08.000000000 +1000
+++ darcs-2.4/tests/issue458.sh	2010-03-01 14:52:54.000000000 +1000
@@ -20,9 +20,7 @@
 darcs record --repodir repo1 -lam x x
 umask 077                       # DENY ALL access to group, all
 darcs get --set-scripts-executable repo1 repo2
-ls -l repo2/x | cut -f 1 -d\  > mode
-echo -rwx------ > desired-mode
-diff -u desired-mode mode
+ls -l repo2/x | cut -f 1 -d\  | grep -- -rwx------
 
 cd ..
 rm -rf temp
msg10090 (view) Author: kowey Date: 2010-03-01.11:15:36
Oh! I didn't notice you sent a patch!  Could I trouble you to send that
as a darcs patch?  Just darcs get --lazy http://darcs.net , record and
send.  This will wind up in our patch tracker.  Thanks,
msg10405 (view) Author: juhp Date: 2010-03-22.03:03:23
sent on 5 Mar from my redhat email.
msg10406 (view) Author: juhp Date: 2010-03-22.04:48:39
Catching up with email...

 http://bugs.darcs.net/patch171
History
Date User Action Args
2010-03-01 11:13:42admincreate
2010-03-01 11:15:40koweysetstatus: unread -> has-patch
topic: + Devel
messages: + msg10090
assignedto: juhp
2010-03-01 11:16:33koweysetnosy: - darcs-bugs
2010-03-22 03:03:27juhpsetassignedto: juhp -> kowey
messages: + msg10405
2010-03-22 04:48:42juhpsetstatus: has-patch -> resolved
assignedto: kowey -> juhp
messages: + msg10406