darcs

Issue 1778 amend-record --patch-name="something" matches only the first time

Title amend-record --patch-name="something" matches only the first time
Priority invalid Status resolved
Milestone 2.5.0 Resolved in 2.4.x
Superseder Nosy List dagit, dmitry.kurochkin, galbolle, jaredj, kowey, volothamp
Assigned To
Topics Matchers, UI

Created on 2010-03-21.13:41:20 by volothamp, last changed 2010-07-23.18:56:44 by tux_rocker.

Messages
msg10369 (view) Author: volothamp Date: 2010-03-21.13:41:12
Something strange with darcs amend-record --patch-name. 

If the parameter matches and you choose not to amend the patch, 
apparently the next patch that is showed doesn't match with it. 

I think it should show you only the patches that matches.
msg10371 (view) Author: kowey Date: 2010-03-21.13:43:51
Thanks! Finding obscure bugs like this is great because it can also
uncover deeper problems.  

We need somebody to figure out what the interaction between
SelectChanges and and matchers was
msg11611 (view) Author: dagit Date: 2010-06-28.03:39:38
Some output for me, given by an older darcs that I had laying around:
$ darcs --exact-version
darcs compiled on May  7 2010, at 21:02:25

Context:

[TAG 2.4.1
Reinier Lamers <tux_rocker@reinier.de>**20100412161826
 Ignore-this: 17bcd98358f6da527cd14ab1a725f0b7
]


Judging by the output I see, patch name filter is not even working.

$ darcs amend-record --patch-name resolve
Tue May 18 08:42:33 PDT 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue1784: push and pull print remote address right away
Shall I amend this patch? [yNvpxq], or ? for help: n
Wed May  5 08:59:19 PDT 2010  Eric Kow <kowey@darcs.net>
  * Accept issue1825: darcs remove with no args leads to buggy pending.
Shall I amend this patch? [yNvpxq], or ? for help: n
Thu May 27 05:10:19 PDT 2010  Petr Rockai <me@mornfall.net>
  * Resolve issue1763: use correct filename encoding in conflictors.
Shall I amend this patch? [yNvpxq], or ? for help: n
Sat May 15 02:08:09 PDT 2010  Eric Kow <kowey@darcs.net>
  * Bump version to 2.4.4.
Shall I amend this patch? [yNvpxq], or ? for help: n
Sat May 15 01:35:29 PDT 2010  Eric Kow <kowey@darcs.net>
  * News entries for Darcs 2.4.4.
Shall I amend this patch? [yNvpxq], or ? for help: n
Tue May 11 14:30:08 PDT 2010  Petr Rockai <me@mornfall.net>
  * Remove more not + redirections usage in testsuite (breaks win32).
Shall I amend this patch? [yNvpxq], or ? for help: q
Amend cancelled.

$ darcs changes | less -X
Tue May 18 08:42:33 PDT 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue1784: push and pull print remote address right away

Wed May  5 08:59:19 PDT 2010  Eric Kow <kowey@darcs.net>
  * Accept issue1825: darcs remove with no args leads to buggy pending.

Thu May 27 05:10:19 PDT 2010  Petr Rockai <me@mornfall.net>
  * Resolve issue1763: use correct filename encoding in conflictors.

Sat May 15 02:08:09 PDT 2010  Eric Kow <kowey@darcs.net>
  * Bump version to 2.4.4.

Sat May 15 01:35:29 PDT 2010  Eric Kow <kowey@darcs.net>
  * News entries for Darcs 2.4.4.

Tue May 11 14:30:08 PDT 2010  Petr Rockai <me@mornfall.net>
  * Remove more not + redirections usage in testsuite (breaks win32).

Tue May 11 14:10:32 PDT 2010  Petr Rockai <me@mornfall.net>
  * Do not redirect output to a file when using "not" to avoid trouble on 
win32.

Sun May  9 06:22:58 PDT 2010  Eric Kow <kowey@darcs.net>
  * Bump version to 2.4.3.

$ darcs amend-record --patch-name Bump
Tue May 18 08:42:33 PDT 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue1784: push and pull print remote address right away
Shall I amend this patch? [yNvpxq], or ? for help: q
Amend cancelled.

$ darcs amend-record --patch-name="Bump"
Tue May 18 08:42:33 PDT 2010  Guillaume Hoffmann <guillaumh@gmail.com>
  * resolve issue1784: push and pull print remote address right away
Shall I amend this patch? [yNvpxq], or ? for help: q
Amend cancelled.



It would appear that --patch-name is being ignored.

Jason
msg11612 (view) Author: kowey Date: 2010-06-28.07:23:40
Hmm, I just noticed that there is both a --patch and --patch-name flag
which recognised.

The --patch flag does what you would expect.

There's a good chance this is just a superficial bug
msg11613 (view) Author: kowey Date: 2010-06-28.07:27:06
Bingo.  Thanks, Jason! Your observation led us to this bit of help text:

"To change the patch name without starting an editor, use --patch-name"

This is the same flag as darcs record -m, not the matcher flag -p
History
Date User Action Args
2010-03-21 13:41:20volothampcreate
2010-03-21 13:43:58koweysetstatus: unknown -> needs-reproduction
nosy: + galbolle, kowey
topic: + Matchers, - ProbablyEasy
messages: + msg10371
2010-06-15 20:52:10adminsetmilestone: 2.5.0
2010-06-15 20:59:50adminsettopic: - Target-2.5
2010-06-28 03:39:39dagitsetnosy: + dagit
messages: + msg11611
2010-06-28 07:23:40koweysetmessages: + msg11612
2010-06-28 07:27:06koweysetpriority: bug -> invalid
status: needs-reproduction -> resolved
messages: + msg11613
nosy: - darcs-devel
2010-07-23 18:56:44tux_rockersetresolvedin: 2.4.x