darcs

Issue 1918 test bug for blacklist feature

Title test bug for blacklist feature
Priority invalid Status wont-fix
Milestone Resolved in
Superseder Nosy List dmitry.kurochkin, test
Assigned To
Topics

Created on 2010-08-14.12:30:28 by kowey, last changed 2010-08-27.13:28:45 by kowey.

Files
File name Uploaded Type Edit Remove
roundup-vacation kowey, 2010-08-14.12:51:38 application/octet-stream
Messages
msg12164 (view) Author: kowey Date: 2010-08-14.12:30:27
Sorry for the noise folks, just testing some work to improve our roundup 
configuration's email management features.
msg12165 (view) Author: kowey Date: 2010-08-14.12:49:18
OK, so the first test revealed that my patch to roundup (attached for the 
curious)
msg12166 (view) Author: kowey Date: 2010-08-14.12:51:38
Err, I meant to say that the first test revealed that my patch to 
roundup seems to have had no ill effects.  Now I've also pushed a change 
to the nosyreaction detector which makes use of this blacklist feature.

Now let's see what happens when I turn on vacation mode for a user.
Hopefully this means the test user is not getting any mail
Attachments
msg12167 (view) Author: kowey Date: 2010-08-14.12:52:56
No effect.  Try restarting Apache?
msg12168 (view) Author: kowey Date: 2010-08-14.12:54:53
Rah
msg12169 (view) Author: kowey Date: 2010-08-14.12:57:35
Hah! I was editing the wrong field.  Have also temporarily disabled bcc 
darcs-devel to avoid spamming people.  NOW does it work?
msg12173 (view) Author: kowey Date: 2010-08-14.13:04:39
Sigh, apparently even not bcc'ing darcs-devel didn't work.
Did I forget to hit save?  Maybe I really do have to restart Apache 
(done)
msg12174 (view) Author: kowey Date: 2010-08-14.13:10:41
I believe this works!

Lessons learned:
 * you have to restart Apache when you modify roundup
 * the current roundup (1.4.13), backported prior to 2010-08-14 lives in 
python-2.5 not 2.4
 * don't forget to unbcc darcs-devel if you're going to much around with 
the BTS

Yes, I know it's really comical that I'm doing these tests live and 
breaking the BTS.  Ideally I should be using Trent's lovely mysql-based 
work to do local testing first, but look either I'm going to get the job 
done, or not get the job done but not get it done right.  Sorry for the 
noise!  [and I will change my ways *some* day...]
msg12176 (view) Author: mornfall Date: 2010-08-14.13:39:35
Comment.
msg12336 (view) Author: kowey Date: 2010-08-27.13:00:57
New test: if the author of the message is not nosy, and he is in the 
blacklist, he should *NOT* receive a message.

This test should fail (see Jason's comments on patch370).  But if I 
repeat this test with my modifications, it should pass
msg12337 (view) Author: kowey Date: 2010-08-27.13:09:21
Brilliant! The test failed in exactly the way I expected.
Now I've pushed a patch to our config, making it so that it accounts for 
the message author as well.  So I think now I should not be in the list 
of recipients.
msg12341 (view) Author: kowey Date: 2010-08-27.13:28:04
Err, that did not work, but I believe that it's because I forgot to 
restart Apache.  How about now.  I should not be in the recipients list.
msg12342 (view) Author: kowey Date: 2010-08-27.13:28:45
Voila! Now author properly taken into account.
History
Date User Action Args
2010-08-14 12:30:28koweycreate
2010-08-14 12:49:19koweysetmessages: + msg12165
2010-08-14 12:51:38koweysetfiles: + roundup-vacation
messages: + msg12166
2010-08-14 12:52:57koweysetmessages: + msg12167
2010-08-14 12:54:54koweysetmessages: + msg12168
2010-08-14 12:57:36koweysetmessages: + msg12169
2010-08-14 13:04:40koweysetmessages: + msg12173
2010-08-14 13:10:42koweysetmessages: + msg12174
2010-08-14 13:39:36mornfallsetmessages: + msg12176
2010-08-27 12:59:53koweysetnosy: - kowey
2010-08-27 13:00:58koweysetmessages: + msg12336
2010-08-27 13:09:22koweysetmessages: + msg12337
2010-08-27 13:28:05koweysetmessages: + msg12341
2010-08-27 13:28:45koweysetmessages: + msg12342