Issue 1920 last regrets prompt in interactive mode

Title last regrets prompt in interactive mode
Priority feature Status resolved
Milestone Resolved in
Superseder Nosy List dmitry.kurochkin, galbolle, kowey
Assigned To
Topics UI

Created on 2010-08-14.16:43:56 by kowey, last changed 2017-07-31.00:31:09 by gh.

msg12178 (view) Author: kowey Date: 2010-08-14.16:43:55
This one could use some Grumpy Old Manning.  I *think* this is Florent's 
suggestion and I've heard something similar from Jason earlier.

Currently in Darcs, there is no way to change your mind about the very 
last patch you select.  You hit 'y' or 'n' and boom, off Darcs goes.  
You also have nothing which forces you to review your selection.

So maybe what we need is a prompt like:

Are you ready to send these patches? [dq...] (or ? for more options).

Notes on the details
1. y/n are NOT available in this prompt.  I tend to suspect that it'd be 
way too easy to blaze through this prompt by hitting 'y' a lot (yes, 
yes, I want this patch and that one and... oops).  So providing 'd' 
instead would act as a forcing function (but not as annoying as asking 
people to type "y-e-s").  Note also that d/q would be consistent with 
the rest of the interface anyway.

2. users can always hit j/k to change their mind on individual patches.
msg12179 (view) Author: kowey Date: 2010-08-14.16:46:32
One more detail: if you have already selected 'a'll or 'd'one, you 
obviously don't need Darcs to prompt you.  This is only for the strict 
'y'/'n' runs.

Also note that if we implement this, we can consider just getting rid of 
the feature that asks for confirmation if you didn't change the file 
msg14533 (view) Author: galbolle Date: 2011-06-15.09:43:42
Adding a flag for disabling this means flag-creep, which i'm not too
keen on. On the other hand, having it always on makes tests like
tests/ask_deps.sh difficult to write (I haven't managed yet). Should we
have a [hidden?] flag, try to detect if the input is interactive, or
maybe use --pipe?
msg14900 (view) Author: kowey Date: 2011-12-29.12:59:18
patch630 sort of fixes this.

I still think 'd' is a better choice than 'y' for the last regrets 
prompt, but I don't have any evidence for this belief (just a hunch).  
The phrasing might be “Hit 'd' to send these patches, 'k' to go back one 
]” (or ? for more options).”

Guillaume had the good observation that it could be good to disable the 
prompt when there is only one patch.

We should also think about avoiding having a million “are you really 
sure you're sure” type questions by fusing this with the 'unrevert 
impossible' prompt (could be tricky!), etc.
msg14901 (view) Author: kowey Date: 2011-12-29.13:00:54
Oh, one reason my "d better than y" belief could be wrong is that it's 
less familiar and might induced wtf-rage.  My hope is that we can use it 
to train users to use the 'd' option more to mean 'ok, all done now' but 
maybe that's a silly desire.  The main motivation is avoid accidentally 
hitting 'y' out of confusion.
Date User Action Args
2010-08-14 16:43:56koweycreate
2010-08-14 16:46:33koweysetmessages: + msg12179
2011-06-15 09:43:43galbollesetmessages: + msg14533
2011-12-29 12:59:19koweysetmessages: + msg14900
2011-12-29 13:00:55koweysetmessages: + msg14901
2017-07-31 00:31:09ghsetstatus: needs-implementation -> resolved