darcs

Issue 20 failure to unrecord in a partial repository.

Title failure to unrecord in a partial repository.
Priority bug Status duplicate
Milestone Resolved in
Superseder unrecord => failed to read patch in get_extra
View: 344
Nosy List darcs-devel, dmitry.kurochkin, kowey, markstos, thorkilnaur, tommy
Assigned To
Topics Partial

Created on 2005-11-24.13:20:07 by droundy, last changed 2009-08-27.13:50:54 by admin.

Messages
msg79 (view) Author: droundy Date: 2005-11-24.13:20:06
On Thu, Nov 24, 2005 at 12:39:41AM +0000, Mark Stosberg wrote:
> I'm sorry for the less-then-useful patch names. When I try to unrecord
> in my darcs-stable repo, I get an error: 
> 
>    Fail: failed to read patch in get_extra:
>    Fri Feb  4 07:37:49 EST 2005  David Roundy <droundy@abridgegame.org>
>      * bump version number to 1.0.2 (at last!)
>    Perhaps this is a 'partial' repository?
> 
> Shouldn't I be able to unrecord, even if /is/ a partial repo?

Hmmm.  Yes, you should be able to unrecord, as long as you don't try to
unrecord a patch that's not available (which I'm sure you weren't trying to
do).  Our handling of partial repositories is pretty fragile, I'm afraid.
Fixes for bugs such as this one also have the benefit of making darcs more
efficient (since the trouble here is that we're reading a patch that in
reality we don't need to read).

If you (or anyone else) could figure out how to generate at test case for
this, that would be most excellent.  The trouble is that very minor changes
in our algorithm can break the handling of partial repositories.  As I
said, it's fragile.  :(  (On the plus side, it's not fragile in any sense
that could lead to corruption.)
-- 
David Roundy
http://www.darcs.net
History
Date User Action Args
2005-11-24 13:20:07droundycreate
2005-11-24 13:38:02droundysetnosy: + markstos
2007-01-07 16:04:06marcotsetnosy: + beschmi, kowey
superseder: + unrecord => failed to read patch in get_extra
2007-01-07 16:05:03marcotlinkissue344 superseder
2007-07-23 13:47:31koweysetstatus: unread -> deferred
nosy: droundy, tommy, beschmi, kowey, markstos
topic: + Partial
2007-08-03 17:27:40droundysetstatus: deferred -> duplicate
2007-08-05 20:04:54koweyunlinkissue344 superseder
2009-08-06 17:33:27adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, thorkilnaur, - droundy
2009-08-06 20:30:56adminsetnosy: - beschmi
2009-08-10 21:53:04adminsetnosy: - darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:48:12adminsetnosy: + darcs-devel, - simon
2009-08-27 13:50:54adminsetnosy: tommy, kowey, markstos, darcs-devel, thorkilnaur, dmitry.kurochkin