darcs

Issue 2014 Can't handle ill form (or illegal) timezone name.

Title Can't handle ill form (or illegal) timezone name.
Priority bug Status wont-fix
Milestone Resolved in
Superseder wish: convert to ISO-8601 as default date format
View: 140
Nosy List eivuokko, jack.bargain, jaredj, kirby, tux_rocker, wglozer
Assigned To
Topics Windows

Created on 2010-12-11.16:30:16 by jack.bargain, last changed 2011-01-05.17:23:34 by kowey.

Files
File name Uploaded Type Edit Remove
unnamed jack.bargain, 2010-12-11.16:30:14 text/html
Messages
msg13317 (view) Author: jack.bargain Date: 2010-12-11.16:30:14
When use following command in my enviroment  (cp936 console, xp simplified
chinese)
darcs can't handle ill form(or illegal) timezone name *"中国标准时间"*, this
timezone name is
produce by XP and endcode in cp936(or gb2312), ms system will allways give
out a "Localize"
timezone name, but not a standardlize one.

*Prelude > let a  = "中国标准时间"*        -- Unicode
*Prelude > a  = "\20013\22269\26631\20934\26102\38388"*

*Prelude System.Time> b <-  getClockTime >>= toCalendarTime>>= \a ->
return(ctTZName a)*
*Prelude System.Time> b
**Prelude System.Time> **"\214\208\185\250\177\234\215\188\202\177\188\228"

*IF *darcs can't pasre such timezone name, why create out ?*
I can't even send a patch because the timezone name.
I can't apply the patch i create even in my repo where i create the patch.

I think just change the unknow timezone name to GMT+ offset (or somekind +
offset)is great!!!!

----------------------------------------------------------------------------------------------------------------------------------------------

darcs changes --last=3

Sat Dec 11 15:13:20
[_<U+00D6>_][_<U+00D0>_][_<U+00B9>_][_<U+00FA>_][_<U+00B1>_]
[_<U+00EA>_][_<U+00D7>_][_<U+00BC>_][_<U+00CA>_][_<U+00B1>_][_<U+00BC>_][_<U+00E
4>_] 2010  Judah Jacobson <judah.jacobson@gmail.com>
  * Fix issues with the "#81 Attempts" patch.

Tue Dec  7 05:55:48
[_<U+00D6>_][_<U+00D0>_][_<U+00B9>_][_<U+00FA>_][_<U+00B1>_]
[_<U+00EA>_][_<U+00D7>_][_<U+00BC>_][_<U+00CA>_][_<U+00B1>_][_<U+00BC>_][_<U+00E
4>_] 2010  Judah Jacobson <judah.jacobson@gmail.com>
  * Attempt to fix #81 on Windows.

Tue Dec  7 05:50:29
[_<U+00D6>_][_<U+00D0>_][_<U+00B9>_][_<U+00FA>_][_<U+00B1>_]
[_<U+00EA>_][_<U+00D7>_][_<U+00BC>_][_<U+00CA>_][_<U+00B1>_][_<U+00BC>_][_<U+00E
4>_] 2010  Judah Jacobson <judah.jacobson@gmail.com>
  * Bump version to 0.6.3.3.

----------------------------------------------------------------------------------------------------------------------------------------------

*darcs send* --*output*=*FILE               **##Here cause apply problem, by
the rediculous timzone name*
*

1 patch for repository http://code.haskell.org/haskeline:

Sat Dec 11 13:56:01 中国标准时间 2010  jack.bargain@gmail.com
  * *Fix "#81 Attempts" Single Line moveRight problem


New patches:

[*Fix "#81 Attempts" Single Line moveRight problem
jack.bargain@gmail.com**20101211055601
 Ignore-this: 5c4f7ec68c00fdfe6699533f93179583
] hunk ./System/Console/Haskeline/Backend/Win32.hsc 294
     moveCoord _ p [] = p
     moveCoord w p cs = case splitAtWidth (w - coordX p) cs of
                         (_,[],len) | len < w -- stayed on same line
-                            -> Coord { coordY = coordY p + 1,
+                            -> Coord { coordY = coordY p,
                                        coordX = coordX p + len
                                      }
                         (_,cs',_) -- moved to next line

Context:
................
*
----------------------------------------------------------------------------------------------------------------------------------------------
*

*
Attachments
msg13329 (view) Author: kowey Date: 2010-12-15.10:46:22
Sorry for the trouble, Jack!  We're getting a little better at encodings 
and internationalisation/localisation related issues, but not enough

Reinier, do you think you might have an opinion on what we should do 
here?

My suggestion is that we just implement issue140
msg13438 (view) Author: tux_rocker Date: 2010-12-31.14:57:20
Op woensdag 15 december 2010 11:46 schreef je:
>internationalisation/localisation related issues, but not enough
> 
> Reinier, do you think you might have an opinion on what we should do 
> here?
> 
> My suggestion is that we just implement issue140

Yes. issue140 means using ISO-8601 dates (YYYY-MM-DD HH:mm:ss+0xy0). That's 
much clearer to a machine than whatever localized string.

Reading the issue140 report, it looks like darcs expects 
System.Time.calendarTimeToString to always return American dates. Maybe Jack's 
problem is that that's true on Unixen but not on Windows.
msg13452 (view) Author: kowey Date: 2011-01-05.17:23:33
Alright, let's try to make the best use of effort here and just 
concentrate on fixing issue140.  Sorry, Jack!
History
Date User Action Args
2010-12-11 16:30:16jack.bargaincreate
2010-12-15 10:46:24koweysetpriority: bug
nosy: + wglozer, tux_rocker, eivuokko, kirby, jaredj
topic: + Windows
messages: + msg13329
2010-12-31 14:57:21tux_rockersetmessages: + msg13438
2011-01-05 17:23:34koweysetstatus: unknown -> wont-fix
superseder: + wish: convert to ISO-8601 as default date format
messages: + msg13452