darcs

Issue 2111 Malformed email address when importing XMonadContrib repo

Title Malformed email address when importing XMonadContrib repo
Priority Status resolved
Milestone Resolved in
Superseder Nosy List owst
Assigned To owst
Topics Bridge

Created on 2011-11-27.19:41:39 by owst, last changed 2011-11-28.20:10:09 by owst.

Messages
msg14826 (view) Author: owst Date: 2011-11-27.19:41:36
Jesper hit another problem, when trying to push to github:
" [...]

    error: object 188c0969e6a6bef20b6bee69c92c5f24bb550d79:invalid
author/committer line - missing space before email


Doing a git fsck, showed that two commits (from the same author) has
this issue.

    error in commit 188c0969e6a6bef20b6bee69c92c5f24bb550d79: invalid
author/committer line - missing space before email
    error in commit 7a7fcfbf6f091497bf9dd8881327a9e00769548d: invalid
author/committer line - missing space before email


Both contains the following author information:

    reenberg@mille:~/src/xmonad/XMonadContrib_git$ git show
188c0969e6a6bef20b6bee69c92c5f24bb550d79 | head -n 4
    commit 188c0969e6a6bef20b6bee69c92c5f24bb550d79
    Author: <its.sec@gmx.net>
    Date:   Thu Feb 7 21:31:00 2008 +0000

 
I guess this is a simple fix of just making sure to add a space during
the fast-import, if there is no author information, and i guess the same
goes if there is no email information."

The author email is missing a name in the darcs patches. We should
probably check the format for correctness 
on import/export and add a "UNKNOWN_AUTHOR" placeholder or something.
History
Date User Action Args
2011-11-27 19:41:39owstcreate
2011-11-28 20:10:09owstsetstatus: needs-reproduction -> resolved