Issue 2210 last regrets with single patch being selected

Title last regrets with single patch being selected
Priority Status unknown
Milestone Resolved in
Superseder Nosy List owst
Assigned To

Created on 2012-07-17.11:09:00 by owst, last changed 2013-09-12.14:39:36 by peachesncream.

File name Uploaded Type Edit Remove
10555-28932-5167.html peachesncream, 2013-09-12.14:39:35 text/html
msg15877 (view) Author: owst Date: 2012-07-17.11:08:58
1. Summarise the issue (what were doing, what went wrong?)

I got annoyed by last regrets, it required me to say 'y' twice, when I
really wanted to say it once.

I temporarily recorded a WIP patch:

  $ darcs rec -am 'WIP'

fooed about a bit (without adding/reordering patches), then decided to
unrecord it:

  $ darcs unrec --last 1
  Shall I unrecord this patch? (1/1)  [ynW...], or ? for more options: y
  Do you want to unrecord these patches? [Yglqk...], or ? for more
options: y

I don't really want to confirm twice that I want to unrecord a patch I
explicitly selected (once is fine, to confirm that I mean the last patch).

2. What behaviour were you expecting instead?

I'm not quite sure, but I *think* what I want is for the normal "do you
want to unrecord this patch" to still be shown, but last regrets not to
show if there is only 1 patch? It seems to be irritating, and not adding
much in this case.

3. What darcs version are you using? (Try: darcs --exact-version)

2.9.1 (+ 548 patches)

4. What operating system are you running?

Ubuntu x86_64
msg15878 (view) Author: galbolle Date: 2012-07-18.10:46:29
You need to make sure that the user knew there would only be one patch
in the selection, or it will make the interface inconsistent:

unrec --last 1 -> no last regrets
obl --match "author johnny_contributes_once" -> use last regrets even
with only one patch
msg15879 (view) Author: owst Date: 2012-07-18.11:04:57
Yes, indeed so.

I suppose my proposal would be to disable last regrets (LR) when --last
1 is used? 

I'm not sure though, for example, do I want LR if --last 2 is used?
Maybe not, but then, where do you draw the line? 

I suppose the answer is for me to use `unrec --last 1 -a`, but then I
lose all control over which patch is picked (maybe that's what I'm
asking for by using --last)...

I can at least say I'm convinced that it's annoying to be asked the same
thing twice in the single patch case, with --last 1.
Date User Action Args
2012-07-17 11:09:00owstcreate
2012-07-18 10:46:30galbollesetmessages: + msg15878
2012-07-18 11:04:58owstsetmessages: + msg15879
2012-09-12 20:59:38owstlinkissue2236 superseder
2013-09-12 14:39:36peachesncreamsetfiles: + 10555-28932-5167.html