darcs

Issue 2211 darcs warns newly added file not in repo only if explicitly mentioned on command line

Title darcs warns newly added file not in repo only if explicitly mentioned on command line
Priority bug Status given-up
Milestone Resolved in
Superseder Nosy List cliffordbeshers
Assigned To
Topics

Created on 2012-07-18.16:44:38 by cliffordbeshers, last changed 2017-07-31.00:43:36 by gh.

Files
File name Uploaded Type Edit Remove
transcript cliffordbeshers, 2012-07-18.16:44:36 application/octet-stream
Messages
msg15880 (view) Author: cliffordbeshers Date: 2012-07-18.16:44:36
1. Summarise the issue (what were doing, what went wrong?)

I get warnings intermittently about files not being in the repository. T hey are always files 
that I have just added.  I finally realized that I only get the message when I have 
explicitly listed the file name on the command line.

2. What behaviour were you expecting instead?

No warning should be given if 'darcs add' has been run on the file.

3. What darcs version are you using? (Try: darcs --exact-version)

darcs compiled on Apr  3 2012, at 09:13:22

Context:

[TAG 2.7.99.1
Florent Becker <florent.becker@ens-lyon.org>**20120401092449
 Ignore-this: 23fef1226d1278f70993402dc13ea30d
] 

Compiled with:

HTTP-4000.2.2
array-0.4.0.0
base-4.5.0.0
bytestring-0.9.2.1
containers-0.4.2.1
directory-1.1.0.2
extensible-exceptions-0.1.1.4
filepath-1.3.0.0
hashed-storage-0.5.9
haskeline-0.6.4.6
html-1.0.1.2
mmap-0.5.7
mtl-2.0.1.0
network-2.3.0.10
old-time-1.1.0.0
parsec-3.1.2
process-1.1.0.1
random-1.0.1.1
regex-compat-0.95.1
tar-0.3.2.0
terminfo-0.3.2.3
text-0.11.1.13
unix-2.5.1.0
vector-0.9.1
zlib-0.5.3.3

4. What operating system are you running?

Ubuntu 12.04 with haskell packages compiled by SeeReason Partners.
Attachments
msg15882 (view) Author: owst Date: 2012-07-18.18:10:00
This has been "fixed" in the darcs.net/screened repo; it looks as if it
was a
serendipitous fix in the patch "remove DarcsFlag from Repository
datatype, use
Darcs.Repository.Flags more" by Guillaume.

Unfortunately the fix is bad, in this case!

Now this warning would be given only *if* --look-for-adds is passed,
which is
the inverse of what I'd expect.

So, I've just sent a patch that:
a) flips this warning, so only if --look-for-adds was *not* passed will
darcs
complain
b) won't complain if the file being recorded has been `darcs add`ed
History
Date User Action Args
2012-07-18 16:44:38cliffordbesherscreate
2012-07-18 18:10:02owstsetmessages: + msg15882
2017-07-31 00:43:36ghsetstatus: needs-implementation -> given-up