Issue 2243 unknown patch in annotate with empty first line of file

Title unknown patch in annotate with empty first line of file
Priority Status resolved
Milestone 2.12.0 Resolved in
Superseder Nosy List fx
Assigned To

Created on 2012-09-28.17:16:52 by fx, last changed 2017-09-21.15:44:15 by bf.

msg16130 (view) Author: fx Date: 2012-09-28.17:16:51
My Emacs mode just broke with a real example of this, but here's a
simple case.  I recorded a trivial file with a blank first line and got
the output below with "unknown" in the label.

  1: Fri Sep 28 18:05:41 BST 2012  Dave Love <d.love@liverpool.ac.uk>
    * x
                    unknown |  
  d.love@liverpool.ac.   #1 | a 
                            | b 
With --machine-readable it's

  19700101000000-0000-0000000000000000000000000000000000000000.gz |  
  20120928170541-0ed77-bad9ce1948ceaad386ea5ed1c9bb000974504be2.gz | a 
  20120928170541-0ed77-bad9ce1948ceaad386ea5ed1c9bb000974504be2.gz | b 
Incidentally, there's a trailing blank line in both types of output; I
wonder if that's intentional.
msg16135 (view) Author: owst Date: 2012-09-29.14:03:46
Ouch. I think this might be another symptom of

The output with machine-readable is a "default patch name", used when
the actual patch is unknown.

The trailing newline is probably not meant to be there.
msg19576 (view) Author: bf Date: 2017-08-13.01:19:28
This has been fixed with the new annotate implementation.
Date User Action Args
2012-09-28 17:16:52fxcreate
2012-09-29 14:03:47owstsetmessages: + msg16135
title: unknown" revision in annotate with empty first line of file -> unknown patch in annotate with empty first line of file
2016-04-04 14:50:07ghsetmilestone: 2.12.0
2017-08-13 01:19:29bfsetstatus: unknown -> has-patch
messages: + msg19576
2017-09-21 15:44:15bfsetstatus: has-patch -> resolved