darcs

Issue 226 pulling a patch as wrong user corrupts repository

Title pulling a patch as wrong user corrupts repository
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, markstos, mboes, thorkilnaur, tommy
Assigned To
Topics

Created on 2006-08-02.01:09:58 by mboes, last changed 2009-08-27.14:04:49 by admin.

Messages
msg834 (view) Author: mboes Date: 2006-08-02.01:09:54
Say a darcs repository was created inside a subdirectory in /home/foo
by user foo. If root pulls a patch into that repo then
_darcs/inventory will change ownership from foo to root. Now any
subsequent pull by user foo will both fail and leave the repository in
an incosistent state, because it cannot record the presence of the new
patches in _darcs/invenory (permission denied). Moreover, patches
cannot be unrecorded or unpulled, even though they have been applied.

darcs should either not change the ownership of _darcs/inventory or
make pulls atomic, ie if darcs pull fails then none of the patches are
applied and the repository is left in its initial state.

Thanks,

Mathieu Boespflug
msg1239 (view) Author: tommy Date: 2006-11-17.12:12:30
The new --umask option might help to work around this problem.

Darcs often creates new files, so even if the inventory owner was preserved (if
possible) many other files would still be created with the wrong owner. And
darcs could not change the file owner uless it was suid, and _that_ would be a
really bad idea. It's better to set the group sticky bit on shared repos and use
the --umask option to keep files group writable.

A more atomic pull (and others) is under development.
msg2584 (view) Author: markstos Date: 2008-01-19.06:06:20
David, 

Would this be addressed by the atomicity of the new hashed or darcs-2 formats? 

  Mark
msg2594 (view) Author: droundy Date: 2008-01-19.12:55:59
Yes, this is addressed by the atomicity of the darcs-2 and hashed formats.
History
Date User Action Args
2006-08-02 01:09:58mboescreate
2006-08-03 16:24:34mboessetnosy: droundy, tommy, mboes
title: pulling a patch as wrong user corrupts directory -> pulling a patch as wrong user corrupts repository
2006-11-17 12:12:37tommysetstatus: unread -> unknown
nosy: + kowey
messages: + msg1239
2008-01-19 06:06:21markstossetnosy: + markstos, beschmi
messages: + msg2584
2008-01-19 12:56:00droundysetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, markstos, mboes
messages: + msg2594
2008-09-04 21:28:51adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:40:41adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, mboes
2009-08-06 20:51:01adminsetnosy: - beschmi
2009-08-10 21:53:48adminsetnosy: + mboes, - darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:55:13adminsetnosy: - dagit
2009-08-25 17:54:13adminsetnosy: + darcs-devel, - simon
2009-08-27 14:04:49adminsetnosy: tommy, kowey, markstos, darcs-devel, mboes, thorkilnaur, dmitry.kurochkin