darcs

Issue 2291 darcs rebase suspend enters the rebase-in-progress state too early, causing "rebase in progress with 0 patches "

Title darcs rebase suspend enters the rebase-in-progress state too early, causing "rebase in progress with 0 patches "
Priority bug Status duplicate
Milestone 2.10.0 Resolved in
Superseder Rebase status message printed even if no patches suspended
View: 2248
Nosy List markstos
Assigned To
Topics Rebase

Created on 2013-01-03.20:48:11 by markstos, last changed 2013-01-03.20:53:01 by markstos.

Messages
msg16519 (view) Author: markstos Date: 2013-01-03.20:48:09
(I thought there was a ticket already for this, but didn't find it when 
searching for "Rebase")

1. Summarise the issue (what were doing, what went wrong?)

There are two ways I know of to trigger this issue:

- darcs rebase suspend -p foo, resulting in "No patches selected!"
- darcs rebase suspend -p zoo, resulting in patches displayed, and then 
manually quiting without selecting any pages. 

At this point. the repo will be stuck in a state of "rebase-in-progress 
with 0 patches selected", even though a rebase was never actually begun.

To get out of the state, you have to make a trivial change into a patch, 
suspend that patch, unsuspend that patch and then oblit that patch to 
get back to the state before the unwanted state was entered.

2. What behaviour were you expecting instead?

darcs rebase should only set the "rebase-in-progress" state after the 
user has confirmed that they want to select some patches to suspend.

3. What darcs version are you using? (Try: darcs --exact-version)

 darcs 2.9.5 (+ 153 patches)
 darcs 2.9.7 (+ 10 patches)

4. What operating system are you running?
  
Ubuntu Linux.
msg16520 (view) Author: markstos Date: 2013-01-03.20:52:59
I think I may have found the other ticket, it appears ticket may be a 
dupe of issue2248
History
Date User Action Args
2013-01-03 20:48:11markstoscreate
2013-01-03 20:53:01markstossetstatus: unknown -> duplicate
messages: + msg16520
superseder: + Rebase status message printed even if no patches suspended
milestone: 2.10.0