darcs

Issue 2299 darcs Setup.lhs with cabal HEAD broken (withTempFile changed)

Title darcs Setup.lhs with cabal HEAD broken (withTempFile changed)
Priority bug Status resolved
Milestone 2.10.0 Resolved in
Superseder Nosy List DaniilFrumin, ian, jaredj, tuncer.ayaz
Assigned To
Topics ProbablyEasy

Created on 2013-02-09.16:51:31 by tuncer.ayaz, last changed 2014-01-20.21:36:59 by DaniilFrumin.

Messages
msg16569 (view) Author: tuncer.ayaz Date: 2013-02-09.16:51:30
The signature of withTempFile has changed in cabal HEAD[1] and
thereby breaks Setup.lhs.

Previously:
withTempFile tmpDir template action

Currently:
withTempFile keepTempFiles tmpDir template action

keepTempFiles is a Bool.

I didn't submit a patch because I'm not sure how to keep Setup.lhs
compatible with old cabal versions.

[1] https://github.com/haskell/cabal/commit/c3a5b96ac
msg16613 (view) Author: kowey Date: 2013-02-16.08:19:12
Fixable with ifdefs?

For history purposes, I assume tuncer.ayaz means what will become Cabal 
1.18. tuncer.ayaz: does the ifdef hint help at all?
msg16619 (view) Author: ganesh Date: 2013-02-16.09:37:36
I don't think there's any symbol defined we can ifdef based on. I 
commented on the github commit:
https://github.com/haskell/cabal/commit/c3a5b96ac#commitcomment-2592366
msg17135 (view) Author: DaniilFrumin Date: 2014-01-20.21:36:58
At the end of the day, the signature for `withTempFIle` didn't change:
<http://hackage.haskell.org/package/Cabal-1.18.1.2/docs/Distribution-Simple-Utils.html#v:withTempFile>

I'll take the liberty of closing this issue, hope you don't mind.
History
Date User Action Args
2013-02-09 16:51:31tuncer.ayazcreate
2013-02-16 08:19:14koweysetstatus: unknown -> needs-implementation
topic: + ProbablyEasy
nosy: + jaredj
messages: + msg16613
priority: bug
milestone: 2.10.0
2013-02-16 09:37:37ganeshsetmessages: + msg16619
2014-01-20 21:36:59DaniilFruminsetstatus: needs-implementation -> resolved
nosy: + DaniilFrumin
messages: + msg17135