darcs

Issue 232 can_I_remove_directories_holding_open_files does not clean up after self

Title can_I_remove_directories_holding_open_files does not clean up after self
Priority bug Status wont-fix
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, megacz, thorkilnaur, tommy
Assigned To droundy
Topics

Created on 2006-08-06.01:37:35 by megacz, last changed 2009-08-27.13:48:07 by admin.

Messages
msg857 (view) Author: megacz Date: 2006-08-06.01:37:32
(assigning to droundy hoping he will reassign to the right person, since I
 don't know who that would be... this isn't important enough for him to fix
 personally)

In CheckFileSystem.lhs, the function can_I_remove_directories_holding_open_files 
opens a file, removes it, then attempts to remove the directory in which that 
file resides.

This will fail on AFS (AFS semantics: when an open file is removed, its inode is 
reattached to the directory as .__afsXXXX until the file is closed ==> hence the 
directory is no longer empty and cannot be removed).  That's no big deal; it 
just means darcs can't use mmap.  But the check function should close the open 
file and then [try to] remove the directory again in order to not leave behind 
droppings.

This manifests itself when you "darcs get" to a destination in /afs/.  Otherwise 
everything works wonderfully.

Thanks!

  - a
msg1054 (view) Author: megacz Date: 2006-10-09.02:09:41
My error, this is actually a bug in OpenAFS on certain platforms.

  http://www.openafs.org/pipermail/openafs-info/2006-October/023804.html

If you delete a file while it's open, a phantom file is created.  However, the 
bug causes OpenAFS to forget to delete this phantom file.  I will work with the 
OpenAFS people to get them to fix this.

Sorry to bother y'all.

  - a
History
Date User Action Args
2006-08-06 01:37:35megaczcreate
2006-10-09 02:09:49megaczsetstatus: unread -> wont-fix
nosy: + kowey
messages: + msg1054
2009-08-06 17:48:17adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, beschmi, thorkilnaur, - droundy, megacz
2009-08-06 20:51:14adminsetnosy: - beschmi
2009-08-10 21:54:09adminsetnosy: + megacz, - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 18:00:00adminsetnosy: + darcs-devel, - simon
2009-08-27 13:48:07adminsetnosy: tommy, kowey, darcs-devel, megacz, thorkilnaur, dmitry.kurochkin