darcs

Issue 2450 dataenc is deprecated in favour of sandi

Title dataenc is deprecated in favour of sandi
Priority Status resolved
Milestone 2.10.2 Resolved in
Superseder Nosy List DaniilFrumin, jshholland
Assigned To DaniilFrumin
Topics

Created on 2015-05-04.15:51:45 by jshholland, last changed 2015-11-02.18:40:25 by gh.

Files
File name Uploaded Type Edit Remove
switch-from-dataenc-_deprecated_-to-sandi.dpatch DaniilFrumin, 2015-10-04.08:21:53 application/octet-stream
unnamed DaniilFrumin, 2015-10-10.17:44:59 text/html
Messages
msg18392 (view) Author: jshholland Date: 2015-05-04.15:51:43
According to the page on Hackage[0], dataenc is deprecated in favour of 
the sandi[1] package. Unfortunately the API is somewhat different. I'll 
have a look at updating the code now. It looks like it's only used in one 
file at least.
msg18393 (view) Author: jshholland Date: 2015-05-04.15:58:20
(forgot the links)

[0]: https://hackage.haskell.org/package/dataenc
[1]: https://hackage.haskell.org/package/sandi
msg18765 (view) Author: DaniilFrumin Date: 2015-10-03.14:08:56
I am going to take a stab at that, on the 2.10 branch.
msg18769 (view) Author: DaniilFrumin Date: 2015-10-04.08:21:53
It turned out to be easier than I thought.
The darcs test suite as well as the hashed-storage test suite runs OK.
Attachments
msg18772 (view) Author: gh Date: 2015-10-09.19:40:53
Hi Dan,

I recall that switching to sandi was problematic for old GHC versions,
and we want 2.10 to support GHC 7.4.

With which GHC versions did you try your patch?

Guillaume
msg18776 (view) Author: DaniilFrumin Date: 2015-10-10.17:44:59
Hi Guillaume,

I have to admit I didn't try anything older than 7.6

Do you have any advice on building/testing darcs with different GHC
versions?
Do I need several GHC installations and several Cabal sandboxes for that?

On Fri, Oct 9, 2015 at 9:40 PM, Guillaume Hoffmann <guillaumh@gmail.com>
wrote:

> Hi Dan,
>
> I recall that switching to sandi was problematic for old GHC versions,
> and we want 2.10 to support GHC 7.4.
>
> With which GHC versions did you try your patch?
>
> Guillaume
>
Attachments
msg18779 (view) Author: ganesh Date: 2015-10-15.22:20:30
I've tried this with GHC 7.4, and while sandi 0.3 doesn't work there it seems 
we can loosen the lower bound to include sandi 0.2. I'll send a followup patch 
to change that.

FWIW I use different GHC installations - I used to just install the binary 
tarballs from the GHC website into different directories, though now I use 
NixOS for that.

You should be able to share the same cabal sandbox directory between different 
GHCs as the packages get installed into directories named after the GHC 
version, unless something goes a bit wrong.
History
Date User Action Args
2015-05-04 15:51:45jshhollandcreate
2015-05-04 15:58:21jshhollandsetmessages: + msg18393
2015-10-03 11:11:01DaniilFruminsetnosy: + DaniilFrumin
2015-10-03 11:11:42DaniilFruminsetassignedto: DaniilFrumin
2015-10-03 14:08:57DaniilFruminsetmessages: + msg18765
2015-10-04 08:21:55DaniilFruminsetstatus: unknown -> has-patch
files: + switch-from-dataenc-_deprecated_-to-sandi.dpatch
messages: + msg18769
2015-10-09 19:40:55ghsetmessages: + msg18772
2015-10-10 17:45:01DaniilFruminsetfiles: + unnamed
messages: + msg18776
2015-10-15 22:20:32ganeshsetmessages: + msg18779
milestone: 2.10.2
2015-11-02 18:40:25ghsetstatus: has-patch -> resolved