darcs

Issue 2478 refactor Darcs.Patch.Prim.V1.Apply

Title refactor Darcs.Patch.Prim.V1.Apply
Priority Status resolved
Milestone Resolved in
Superseder Nosy List gh
Assigned To
Topics Core, Performance

Created on 2015-11-07.18:52:32 by gh, last changed 2020-06-21.10:20:23 by bfrk.

Messages
msg18840 (view) Author: gh Date: 2015-11-07.18:52:28
The whole applyHunks/applyHunkLines business in
Darcs.Patch.Prim.V1.Apply (the only places that call
break{After,Before}NthNewline) should be documented, commented, and
probably refactored. breakAfterNthNewline and breakBeforeNthNewline
(from Darcs.Utils.ByteString) may end up moved to that module too.

I also hope we gain some performance on patch application by doing this.

(This is a followup from http://bugs.darcs.net/patch1406 ).
msg22095 (view) Author: bfrk Date: 2020-06-21.10:20:21
resolved by

patch 33fba47adbf043d882560351297e90ca73fa2a0d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Feb 22 10:58:00 CET 2018
  * refactor, simplify, and document hunk application
History
Date User Action Args
2015-11-07 18:52:32ghcreate
2020-06-21 10:20:23bfrksetstatus: unknown -> resolved
messages: + msg22095