Issue 2582: use of </> from native System.FilePath in Darcs.Util.URL.sshFilePathOf - Darcs bug tracker

Title	use of </> from native System.FilePath in Darcs.Util.URL.sshFilePathOf
Priority	invalid	Status	resolved
Milestone		Resolved in
Superseder		Nosy List	bfrk
Assigned To		Topics

Created on 2018-03-25.19:59:03 by bfrk, last changed 2018-11-26.10:49:15 by kowey.

Messages
msg20034 (view)	Author: bfrk	Date: 2018-03-25.19:59:01
I think this is a bug because on Windows </> may use '\' and that is probably not allowed in ssh URLs. Ganesh, could you comment?
msg20036 (view)	Author: ganesh	Date: 2018-03-26.05:55:39
I agree it seems wrong, but looking at the code in Darcs.Util.SSH, I think it's only used for the local filename, and in debug messages. Also, this code hasn't changed for a long time and SSH URLs do work ok for me.
msg20037 (view)	Author: ganesh	Date: 2018-03-26.05:56:40
Actually I take back "it seems wrong" - if its use is constrained like that, it's probably correct to use the local path separator.
msg20044 (view)	Author: bfrk	Date: 2018-03-26.19:37:07
Okay, will close.

History
Date	User	Action	Args
2018-03-25 19:59:03	bfrk	create
2018-03-26 05:55:40	ganesh	set	messages: + msg20036
2018-03-26 05:56:41	ganesh	set	messages: + msg20037
2018-03-26 19:37:09	bfrk	set	priority: invalid messages: + msg20044
2018-11-26 10:49:15	kowey	set	status: unknown -> resolved