darcs

Issue 2582 use of from native System.FilePath in Darcs.Util.URL.sshFilePathOf

Title use of </> from native System.FilePath in Darcs.Util.URL.sshFilePathOf
Priority invalid Status unknown
Milestone Resolved in
Superseder Nosy List bf
Assigned To
Topics

Created on 2018-03-25.19:59:03 by bf, last changed 2018-03-26.19:37:09 by bf.

Messages
msg20034 (view) Author: bf Date: 2018-03-25.19:59:01
I think this is a bug because on Windows </> may use '\' and that is
probably not allowed in ssh URLs.

Ganesh, could you comment?
msg20036 (view) Author: ganesh Date: 2018-03-26.05:55:39
I agree it seems wrong, but looking at the code in Darcs.Util.SSH, I 
think it's only used for the local filename, and in debug messages. 
Also, this code hasn't changed for a long time and SSH URLs do work ok 
for me.
msg20037 (view) Author: ganesh Date: 2018-03-26.05:56:40
Actually I take back "it seems wrong" - if its use is constrained like 
that, it's probably correct to use the local path separator.
msg20044 (view) Author: bf Date: 2018-03-26.19:37:07
Okay, will close.
History
Date User Action Args
2018-03-25 19:59:03bfcreate
2018-03-26 05:55:40ganeshsetmessages: + msg20036
2018-03-26 05:56:41ganeshsetmessages: + msg20037
2018-03-26 19:37:09bfsetpriority: invalid
messages: + msg20044