darcs

Issue 2588 clone creates target repo with wrong permissions

Title clone creates target repo with wrong permissions
Priority Status resolved
Milestone Resolved in 2.15.0
Superseder Nosy List bf
Assigned To
Topics

Created on 2018-05-28.14:37:39 by bf, last changed 2020-06-20.10:35:56 by bf.

Messages
msg20132 (view) Author: bf Date: 2018-05-28.14:37:38
The permissions are always drwx------, no matter what umask is set. This
is due to the use of withTempDirectory, which explicitly creates the
temporary directory with these permissions (on Unix), as I found out
just now.

The bug is in 2.12.5, 2.14.0, and screened, but not in 2.12.4.
msg20133 (view) Author: bf Date: 2018-05-28.14:54:56
Correction: 2.12.5 does not have this bug, but 2.14.0 has.
msg20134 (view) Author: bf Date: 2018-05-28.15:25:37
I have a fix for this. It removes the use of withTempDirectory and thus
the dependency on the temporary package. I can either apply it to
screened, but then, when I pull it into branch-2.14, it pulls along
another patch with a change in darcs.cabal, which (I think) we want to
roll back in 2.14.x. Or I can make it apply cleanly to 2.14 but then I
get a conflict when I pull it into screened.

My current choice is the latter (i.e. send conflicting fix plus
resolution to screened). I'll send it as such but will await approval
before I push to screened.
msg22056 (view) Author: bf Date: 2020-06-20.10:35:54
resolved by

patch 4313c6925a27110cc2356753f2d277f066f15b5f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed May 30 18:35:09 CEST 2018
  * resolve conflicts after pulling fix for issue2588 from branch-
2.14
Shall I view this patch? (1/?) [yN...], or ? for more options: n
patch 68a9016047b107486e49b1761ee6a58afd88a487
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed May 30 14:27:32 CEST 2018
  * resolve issue2588: no longer use withTempDirectory in 
withNewDirectory
History
Date User Action Args
2018-05-28 14:37:39bfcreate
2018-05-28 14:54:58bfsetmessages: + msg20133
2018-05-28 15:25:38bfsetmessages: + msg20134
2020-06-20 10:35:56bfsetstatus: unknown -> resolved
messages: + msg22056
resolvedin: 2.15.0