darcs

Issue 2604 Remove --reply option

Title Remove --reply option
Priority Status unknown
Milestone Resolved in
Superseder Nosy List bf
Assigned To
Topics

Created on 2018-10-12.22:24:42 by bf, last changed 2018-10-16.07:31:23 by bf.

Messages
msg20398 (view) Author: bf Date: 2018-10-12.22:24:40
Sending email is not our core business. The option can be easily 
replaced with a pre or post hook script. And its implementation 
requires complicated low-level fiddling with exception handlers and 
temporary files, see redirectOutput In ApplyPatches and withStdoutTemp 
which is implemented in darcs.Util.Compat.
msg20404 (view) Author: ganesh Date: 2018-10-16.05:40:13
I think this is sensible. I had a quick look on darcs.net and I
don't think we're using --reply there, instead there's a posthook.

We should also drop the --cc and --sendmail-command from apply
at the same time.

However, darcs send also sends email and is useful, at least for
us as long as we have the current patch tracker. How much of the 
nasty code is specific to apply?
msg20407 (view) Author: bf Date: 2018-10-16.07:31:21
See patch1742 for details of what will be removed. Sending email via 
darcs send is not affected.
History
Date User Action Args
2018-10-12 22:24:42bfcreate
2018-10-16 05:40:15ganeshsetmessages: + msg20404
2018-10-16 07:31:23bfsetmessages: + msg20407