Issue 2626 treat applyToWorking more uniformly

Title treat applyToWorking more uniformly
Priority Status unknown
Milestone Resolved in
Superseder Nosy List bf
Assigned To

Created on 2019-06-16.12:07:10 by bf, last changed 2019-06-16.12:07:10 by bf.

msg20844 (view) Author: bf Date: 2019-06-16.12:07:07
We sould factor catching of IO exceptions into applyToWorking to 
reduce duplication, now that we do it uniformly whenever we call it.

We also sometimes call applyToWorking inside withSignalsBlocked but 
not uniformly. We do it for clone (when conflicts are marked), 
unrevert, mark-conflicts, and for pull and apply via 
standardApplyPatches. But not for rollback, revert, unrecord, 
replace, rebase suspend/unsuspend.

I fail to see the pattern here.

The apparent rationale for withSignalsBlocked is that an interrupt 
(user hitting Ctrl-C) would mean that changes may be applied 
partially, leaving the working tree in an inconsistent state. Makes 
sense but again I can't see a reason not to do this uniformly, which 
means we can also factor it into applyToWorking.
Date User Action Args
2019-06-16 12:07:10bfcreate