On 05/08/2019 23:40, Ben Franksen wrote:
> Ben Franksen <firstname.lastname@example.org> added the comment:
>> Personally I often review patches on the tracker using
>> patch-preview.txt, which I guess is generated from the same
>> information. It's quicker than downloading the patch locally for
>> easy reviews. I also not a normal user though.
> Yes, the patch-preview.txt is useful, I also use it occasionally. But it
> doesn't contain context lines.
Oh yes, and I hadn't even realised :-) No objections then.
> More generally, I think we should rather move towards improving darcsden
> with an "apply request" feature, akin to what github introduced with
> their "pull requests". So when I clone a repo from hub.darcs.net, make a
> change, record that, then say 'darcs send', this opens an "apply
> request" in the issue tracker associated to the repo, where we can
> discuss the patch, view its status (e.g. does it apply cleanly or are
> there conflicts?) and also view its effect, ideally with side-by-side
> listing of hunks. For darcsden it would be quite possible to store such
> patches in a separate sibling repo, simulating an in-repo branch.
Agreed. We do already have some support for sending patches to darcsden
but I don't think it's very usable in practice yet. (I wouldn't even
store the patches in a repo, they could just be shown/diffed on demand)