darcs

Issue 297 --list-options fails when command cannot be run

Title --list-options fails when command cannot be run
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, thorkilnaur, tommy
Assigned To kowey
Topics ProbablyEasy

Created on 2006-10-13.09:46:43 by kowey, last changed 2009-08-27.14:11:04 by admin.

Messages
msg1079 (view) Author: kowey Date: 2006-10-13.09:46:28
Import of RT #214

David Roundy <droundy@abridgegame.org> 2005-02-09
-------------------------------------------------

On Wed, Feb 09, 2005 at 07:45:19PM +0200, Vassilii Khachaturov wrote:
> Here is a transcript:
>
> vassilii@ilmarinen:~$ darcs trackdown --he[TAB pressed]
> darcs failed: Can't run command trackdown here.
> You need to be in a repository directory to run this command.
> [output paused, ENTER pressed]

The problem here is that the bash completion calls darcs trackdown
--list-options to find out what flags exist, but this command fails because
darcs trackdown itself may only be run in a repository.

So the fix is to make --list-options able to run (as is the case with
--help) even when in a situation where the command itself cannot be run.
This isn't entirely trivial, since some features (e.g. completing for pull
using the repositories in _darcs/prefs/repos) won't work if you aren't in a
repository. Still, this shouldn't be *too* hard to fix.
msg1080 (view) Author: kowey Date: 2006-10-13.09:48:06
Note that this is still an issue with darcs 1.0.8
msg1819 (view) Author: kowey Date: 2007-07-13.20:55:00
Actually, maybe this should be a wont-fix.  I dunno.  In any case, it might not
be very easy to fix (see Darcs.Commands.run_command) because commands might need
to do their path-correction trickery in order for some of the completions to be
correct (I'm sort of guessing here).

Whoever looks into this might want to tread carefully.
msg1904 (view) Author: kowey Date: 2007-07-23.07:43:14
Will-fix after all.  Resolved in unstable with the following patch.  Thanks!

Mon Jul 16 23:06:31 CEST 2007  Eric Kow <eric.kow@loria.fr>
  * Allow --list-options even if command cannot be run (issue297).
  
  If the command cannot be run, just print the possible flags, not the file args.
History
Date User Action Args
2006-10-13 09:46:43koweycreate
2006-10-13 09:48:16koweysetstatus: unread -> unknown
nosy: droundy, tommy, kowey
messages: + msg1080
2007-07-13 20:55:01koweysetnosy: + beschmi
messages: + msg1819
2007-07-23 07:43:15koweysetstatus: unknown -> resolved-in-unstable
messages: + msg1904
2007-07-23 14:09:43koweysettopic: - FromRequestTracker
2007-07-31 17:59:08koweysetstatus: resolved-in-unstable -> resolved-in-stable
2008-09-16 21:30:25adminsetstatus: resolved-in-stable -> resolved
nosy: + dagit
2009-08-06 17:47:43adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy
2009-08-06 20:43:30adminsetnosy: - beschmi
2009-08-10 21:56:47adminsetnosy: - markstos, darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:56:48adminsetnosy: - dagit
2009-08-25 17:59:28adminsetnosy: + darcs-devel, - simon
2009-08-27 14:11:04adminsetnosy: tommy, kowey, darcs-devel, thorkilnaur, dmitry.kurochkin