darcs

Issue 302 trim context for "darcs send" at "first" TAG

Title trim context for "darcs send" at "first" TAG
Priority wishlist Status resolved
Milestone Resolved in
Superseder Nosy List SamB, darcs-devel, dmitry.kurochkin, kowey, markstos, thorkilnaur, tommy
Assigned To
Topics

Created on 2006-10-14.22:28:16 by SamB, last changed 2009-08-27.14:05:29 by admin.

Files
File name Uploaded Type Edit Remove
inliner.dpatch SamB, 2006-10-17.20:31:45 text/x-darcs-patch
Messages
msg1090 (view) Author: SamB Date: 2006-10-14.22:28:15
Many mailing lists have size limits for messages. It would be nice if darcs
could commute irrelevant patches out of the context, to reduce the chances of
the patch landing in the moderation queue. (For instance, cvs-ghc@haskell.org,
the default destination for GHC patches.)
msg1091 (view) Author: kowey Date: 2006-10-15.04:25:18
On Sat, Oct 14, 2006 at 22:28:19 +0000, Samuel Bronson wrote:
> Many mailing lists have size limits for messages. It would be nice if darcs
> could commute irrelevant patches out of the context, to reduce the chances of
> the patch landing in the moderation queue. (For instance, cvs-ghc@haskell.org,
> the default destination for GHC patches.)

Hi,

This is something I was supposed to implement, but I have since set it
aside and think somebody else should do it.  The good news is that David
seems to be working on hashed inventory right now,  which is good in
that the hashed inventory feature also needs some kind of minimal
context feature.  You might see this moving forward some day.

More details here:
  http://www.mail-archive.com/darcs-devel@darcs.net/msg02118.html

Also perhaps closer to what you're specifically asking for:
  http://www.abridgegame.org/pipermail/darcs-devel/2004-November/000639.html
  http://www.abridgegame.org/pipermail/darcs-users/2004-July/002519.html
msg1118 (view) Author: droundy Date: 2006-10-17.16:05:13
Actually, the hashed inventory as implemented won't need a
minimal-context.  It's the signed patches idea that requires that...

David
msg1123 (view) Author: SamB Date: 2006-10-17.19:17:18
I don't care how it works, as long as I can send patches to a mailing list
without having context push them over the size limit regardless of the size of
the changes I made. (Not necessarily all the time, but more often at least.)

I like the "minimal" and "minimal, assuming this tag" options from: 

http://www.abridgegame.org/pipermail/darcs-devel/2004-November/000641.html

Except that I do have a destination repository, I just don't care to list all
the patches that I my repo shares with it. (I'd especially like it if I didn't
have to pick the tag.)
msg1124 (view) Author: droundy Date: 2006-10-17.19:37:02
On Tue, Oct 17, 2006 at 07:17:24PM +0000, Samuel Bronson wrote:
> I don't care how it works, as long as I can send patches to a mailing list
> without having context push them over the size limit regardless of the size of
> the changes I made. (Not necessarily all the time, but more often at least.)

You already get this, if you tag your repository.  As long as you tag
regularly, the context sent should remain small.

David
msg1125 (view) Author: SamB Date: 2006-10-17.20:31:45
So how do you explain this file? It has a bunch of TAG patches in it, and lots
of others that must surely have been included in the tags. And I'm running 1.0.8
(release). And I just made this patch file with "darcs send -o", so I know I
made it with this version of darcs.

(Should I mention that my working copy is a --partial repository?)
Attachments
msg1127 (view) Author: droundy Date: 2006-10-17.23:00:00
On Tue, Oct 17, 2006 at 08:31:51PM +0000, Samuel Bronson wrote:
> So how do you explain this file? It has a bunch of TAG patches in it, and lots
> of others that must surely have been included in the tags. And I'm running 1.0.8
> (release). And I just made this patch file with "darcs send -o", so I know I
> made it with this version of darcs.
> 
> (Should I mention that my working copy is a --partial repository?)

You may need to run darcs optimize --reorder on either your working
directory or central repository.  More likely the former.

Darcs should be smarter about this, though...
-- 
David Roundy
Dept. of Physics
Oregon State University
msg1129 (view) Author: SamB Date: 2006-10-17.23:07:31
Doesn't seem to help. At least, not on mine -- I don't exactly have commit
access to the GHC repo...
msg1132 (view) Author: droundy Date: 2006-10-17.23:12:39
On Tue, Oct 17, 2006 at 11:07:33PM +0000, Samuel Bronson wrote:
> Doesn't seem to help. At least, not on mine -- I don't exactly have commit
> access to the GHC repo...

You could test by sending to a local copy of the GHC repo.

David
msg2941 (view) Author: markstos Date: 2008-01-31.02:47:49
Developers:

To re-cap this report, it's wish for darcs to generate smaller messages with
less context. Tagging was recommended, but it seems an "optimize --reorder"
didn't help in this case. 

- Should we expect better luck with the Darcs 2 repo format? If so perhaps this
can be considered "resolved"

- Is there any thing else that makes sense to do here besides recommend
"optimize --reorder" ?  If not, considering this "resolved" or "wont-fix" seems
in order.
msg2982 (view) Author: droundy Date: 2008-01-31.16:30:25
I think resolved is probably appropriate.  It's possible that we could reduce
the context somewhat by running optimize on the remote repository ourselves. 
But with darcs2, optimize is automatically run, so the repository should remain
in good shape, and the context should be small.

David
History
Date User Action Args
2006-10-14 22:28:16SamBcreate
2006-10-15 00:06:43SamBsetnosy: droundy, tommy, kowey, SamB
title: trim context for "darcs send" to mailing lists -> --minimal-context option for "darcs send" to mailing lists
2006-10-15 04:25:40koweysetstatus: unread -> unknown
nosy: droundy, tommy, kowey, SamB
messages: + msg1091
title: --minimal-context option for "darcs send" to mailing lists -> trim context for "darcs send" to mailing lists
2006-10-17 16:05:29droundysetnosy: droundy, tommy, kowey, SamB
messages: + msg1118
2006-10-17 19:17:24SamBsetnosy: droundy, tommy, kowey, SamB
messages: + msg1123
2006-10-17 19:37:10droundysetnosy: droundy, tommy, kowey, SamB
messages: + msg1124
2006-10-17 20:31:51SamBsetpriority: feature -> bug
files: + inliner.dpatch
messages: + msg1125
nosy: droundy, tommy, kowey, SamB
title: trim context for "darcs send" to mailing lists -> trim context for "darcs send" at "first" TAG
2006-10-17 20:33:19SamBsetnosy: droundy, tommy, kowey, SamB
title: trim context for "darcs send" at "first" TAG -> darcs doesn't trim context for "darcs send" at "first" TAG
2006-10-17 23:00:06droundysetnosy: droundy, tommy, kowey, SamB
messages: + msg1127
title: darcs doesn't trim context for "darcs send" at "first" TAG -> trim context for "darcs send" at "first" TAG
2006-10-17 23:07:33SamBsetnosy: droundy, tommy, kowey, SamB
messages: + msg1129
2006-10-17 23:12:40droundysetnosy: droundy, tommy, kowey, SamB
messages: + msg1132
2008-01-31 02:47:50markstossetpriority: bug -> wishlist
nosy: + markstos, beschmi
messages: + msg2941
2008-01-31 16:30:27droundysetstatus: unknown -> resolved-in-unstable
nosy: droundy, tommy, beschmi, kowey, markstos, SamB
messages: + msg2982
2008-09-04 21:29:39adminsetstatus: resolved-in-unstable -> resolved
nosy: + dagit
2009-08-06 17:34:25adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, zooko, mornfall, simon, thorkilnaur, - droundy, SamB
2009-08-06 20:52:19adminsetnosy: - beschmi
2009-08-10 21:57:00adminsetnosy: + SamB, - darcs-devel, zooko, jast, Serware, mornfall
2009-08-10 23:56:54adminsetnosy: - dagit
2009-08-25 17:49:00adminsetnosy: + darcs-devel, - simon
2009-08-27 14:05:29adminsetnosy: tommy, kowey, markstos, darcs-devel, SamB, thorkilnaur, dmitry.kurochkin