darcs

Issue 343 wish: external-merge does not handle add conflicts well

Title wish: external-merge does not handle add conflicts well
Priority wishlist Status wont-fix
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, markstos, thorkilnaur, tommy
Assigned To
Topics Conflicts

Created on 2006-11-12.22:22:56 by kowey, last changed 2009-09-02.14:31:46 by kowey.

Messages
msg1208 (view) Author: kowey Date: 2006-11-12.22:22:51
The following dies because the file that is added on both sides does not
exist in the ancestor and the external program (reasonably) complains.
I guess this is something that happens rarely enough for it to be
relatively unimportant, but it may be worth fixing.

---------8<----------------

mkdir un
cd un
darcs init
touch a
darcs add a
darcs record --all --author moi -m "a"
cd ..

mkdir deux 
cd deux 
darcs init
touch a
darcs add a
darcs record --all --author moi -m "a"
cd ..

cd deux
darcs pull ../un --external-merge="opendiff %1 %2 -ancestor %a -merge %o"
msg2944 (view) Author: markstos Date: 2008-01-31.02:57:38
"The following dies because the file that is added on both sides does not
exist in the ancestor and the external program (reasonably) complains.
I guess this is something that happens rarely enough for it to be
relatively unimportant, but it may be worth fixing."

Eric, 

What do you think the reasonable fix might look like here? It's not clear to me
offhand what I would expect darcs to do differently here. 

  Mark
msg3081 (view) Author: kowey Date: 2008-02-03.11:08:46
On Thu, Jan 31, 2008 at 02:57:39 -0000, Mark Stosberg wrote:
> What do you think the reasonable fix might look like here? It's not clear to me
> offhand what I would expect darcs to do differently here. 

Me neither.  I suppose for this particular case, merge tools might be
happier if an empty version of the file was created in the ancestor.
But how to go about it in a principled fashion is not so clear.
msg3082 (view) Author: markstos Date: 2008-02-03.13:54:57
I'm re-framing this as a wishlist item. Since no correct behavior is known, it
seems difficult to think of this as a bug.  I'm also marking at  as "need
example", since it seems like the next step is for someone to go through several
possible conflict cases, and make a proposal about how "external-merge" should
work in each.
msg3098 (view) Author: droundy Date: 2008-02-04.15:33:37
Yes, Mark.  That seems like an accurate analysis (and reprioritizing).
msg8638 (view) Author: kowey Date: 2009-09-02.14:31:43
I think we can wont-fix this due to darcs-2 semantics accepting duplicate patches.
History
Date User Action Args
2006-11-12 22:22:56koweycreate
2007-03-09 15:23:32koweysetnosy: + beschmi
2008-01-31 02:57:39markstossetstatus: unread -> unknown
nosy: + markstos
messages: + msg2944
2008-02-03 11:08:47koweysetnosy: droundy, tommy, beschmi, kowey, markstos
messages: + msg3081
2008-02-03 13:54:58markstossetpriority: bug -> wishlist
status: unknown -> waiting-for
messages: + msg3082
nosy: droundy, tommy, beschmi, kowey, markstos
2008-02-04 15:33:38droundysetnosy: droundy, tommy, beschmi, kowey, markstos
messages: + msg3098
2008-02-17 01:32:59markstossetnosy: droundy, tommy, beschmi, kowey, markstos
title: external-merge does not handle add conflicts well -> wish: external-merge does not handle add conflicts well
2009-08-06 17:50:41adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, thorkilnaur, - droundy
2009-08-06 20:52:43adminsetnosy: - beschmi
2009-08-10 21:58:42adminsetnosy: - darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 18:02:01adminsetnosy: + darcs-devel, - simon
2009-08-27 13:55:52adminsetnosy: tommy, kowey, markstos, darcs-devel, thorkilnaur, dmitry.kurochkin
2009-09-02 14:31:46koweysetstatus: waiting-for -> wont-fix
nosy: tommy, kowey, markstos, darcs-devel, thorkilnaur, dmitry.kurochkin
topic: + Conflicts
messages: + msg8638