darcs

Issue 347 Mention or support quotes in defaults documentation

Title Mention or support quotes in defaults documentation
Priority wishlist Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, kowey, markstos, thorkilnaur, tommy, ykardia
Assigned To markstos
Topics ProbablyEasy

Created on 2006-11-14.19:44:50 by ykardia, last changed 2009-08-27.13:52:22 by admin.

Messages
msg1215 (view) Author: ykardia Date: 2006-11-14.19:44:39
I sent this message to darcs-users, and Eric suggested that this might
be a bug. He says that he can reproduce it.

----------------------------------
I am trying to use Apple's opendiff to view diffs of files, and put this line
into my .darcs/defaults:
diff diff-command "opendiff %1 %2"

When I run a diff on great_plan.txt in the directory 'myproject', I get
$ darcs diff great_plan.txt
Running command 'opendiff old-myproject/great_plan.txt
new-myproject/great_plan.txt' darcs: /private/tmp/new-myproject:
setCurrentDirectory: does not exist (No such file or directory)

This works when I give the --diff-command option explicitly:
$ darcs diff --diff-command 'opendiff %1 %2' recoveries.tex
Running command 'opendiff old-recoveries/recoveries.tex
new-recoveries/recoveries.tex'
Hit return to move on...
<opendiff pops up shown>

What's wrong?

darcs version: 1.0.8 (release)
compiled with ghc 6.4
Mac OS X 10.4.8
-----------------------

Also, the problem seems appears regardless of what the actual
diff-command is set to.
msg1248 (view) Author: kowey Date: 2006-11-18.18:32:16
On darcs-users, Benjamin Franksen noticed that this was because of the quotes. 
Removing the quotes makes it all work.  He advises that this be mentioned in the
documentation.

(Maybe another way to go about it is to automatically strip a layer of quotes
from the arguments, just like we strip the dashdash?)

(Another mystery is why the quotes don't show up in the output, "Running
command...")
msg1249 (view) Author: kowey Date: 2006-11-18.18:42:09
The place to look is ArgumentDefaults.lhs
msg2297 (view) Author: markstos Date: 2008-01-01.16:54:14
I just submitted a doc patch to darcs-devel for this.
msg2313 (view) Author: droundy Date: 2008-01-04.20:26:37
On Tue, Jan 01, 2008 at 04:54:15PM -0000, Mark Stosberg wrote:
> I just submitted a doc patch to darcs-devel for this.

Somehow I don't seem to have this patch in my mailbox.  What's its name,
and could you resend? (This could just be my current email ineptitude...)
-- 
David Roundy
Department of Physics
Oregon State University
msg2342 (view) Author: markstos Date: 2008-01-07.01:29:51
David replied on-list that my patch was applied, so I'm marking this as "resolved".
History
Date User Action Args
2006-11-14 19:44:50ykardiacreate
2006-11-18 18:32:23koweysetstatus: unread -> unknown
nosy: droundy, tommy, kowey, ykardia
messages: + msg1248
title: diff-command in defaults fails -> setCurrentDirectory problem? -> Mention or support quotes in defaults documentation
2006-11-18 18:42:14koweysettopic: + ProbablyEasy
nosy: droundy, tommy, kowey, ykardia
messages: + msg1249
2008-01-01 16:54:16markstossetstatus: unknown -> testing
nosy: + markstos, beschmi
messages: + msg2297
2008-01-04 20:26:38droundysetmessages: + msg2313
2008-01-07 01:29:53markstossetstatus: testing -> resolved
messages: + msg2342
2009-08-06 17:49:06adminsetnosy: + jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, thorkilnaur, - droundy, ykardia
2009-08-06 20:52:52adminsetnosy: - beschmi
2009-08-10 21:58:51adminsetnosy: + ykardia, - darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 18:00:57adminsetnosy: + darcs-devel, - simon
2009-08-27 13:52:22adminsetnosy: tommy, kowey, markstos, darcs-devel, ykardia, thorkilnaur, dmitry.kurochkin