When doing any command that uses ssh, I get a directory called "darcs-ssh" left
behind after it finishes (with Windows set up as it is for me, darcs uses the
current directory for temporary files).  I'd be inclined to blame
External.controlMasterPath for this (called by External.getSSH), since it
creates this directory with no provision to tidy it up afterwards.  I don't
understand the CM stuff well enough to attempt to fix it, though. (In the
meantime, creating C:\tmp\ makes darcs put tempfiles there, so it's out of the way)

Worth fixing.

On Wed, Nov 15, 2006 at 09:43:59 +0000, Edwin wrote:
> When doing any command that uses ssh, I get a directory called "darcs-ssh" left
> behind after it finishes (with Windows set up as it is for me, darcs uses the
> current directory for temporary files).  I'd be inclined to blame
> External.controlMasterPath for this (called by External.getSSH), since it
> creates this directory with no provision to tidy it up afterwards.

External.exitSSHControlMaster should probably do it.

In more troubling news, control-C'ing some ssh stuff leaves the CM
socket around.  I'll file another bug.

From an email to darcs-users:

| The problem is that when doing a get, push or pull via SSH,
| directories named darcs-ssh are created. I saw them inside the
| working copy, in the directory immediately above the root of the
| working copy and in _darcs/pristine.

From a darcs source comment:

| The location of that directory is determined by the contents of
| _darcs/prefs/tmpdir, if it exists, otherwise by DARCS_TMPDIR,
| and if that doesn't exist then TMPDIR, and if that doesn't
| exist, then /tmp. Finally, if none of those exist (as may be the
| case under windows) it creates the temporary directory in the
| current directory. So you'd better not call it while in
| _darcs/current...

I seems controlMasterPath (which calls tempdir_loc, for which the quoted comment
applies) _is_ called while in _darcs/pristine, and also in other places, at random.

On Thu, Nov 16, 2006 at 08:12:49PM +0000, Tommy Pettersson wrote:
> >From a darcs source comment:
> 
> | The location of that directory is determined by the contents of
> | _darcs/prefs/tmpdir, if it exists, otherwise by DARCS_TMPDIR,
> | and if that doesn't exist then TMPDIR, and if that doesn't
> | exist, then /tmp. Finally, if none of those exist (as may be the
> | case under windows) it creates the temporary directory in the
> | current directory. So you'd better not call it while in
> | _darcs/current...
> 
> I seems controlMasterPath (which calls tempdir_loc, for which the quoted comment
> applies) _is_ called while in _darcs/pristine, and also in other places, at random.

Oi.  That's bad.  At a minimum, we should verify that _darcs is not in the
path of the current working directory.  That shouldn't be hard.
-- 
David Roundy
Deptartment of Physics
Oregon State University

Would this bug be fixed by the recent patch named:

"avoid creating darcs-ssh if we aren't using ControlMaster." ?

Yes.