darcs

Issue 356 Misleading error

Title Misleading error
Priority bug Status resolved
Milestone Resolved in
Superseder Nosy List darcs-devel, dmitry.kurochkin, jch, kowey, simonpj, thorkilnaur, tommy
Assigned To
Topics

Created on 2006-11-24.10:16:24 by simonpj, last changed 2009-08-27.13:48:22 by admin.

Messages
msg1263 (view) Author: simonpj Date: 2006-11-24.10:16:19
I set my defaultrepo file to
        simonpj@microsoft.com:/home/darcs/packages/base
and tried to push.  Here's what Darcs said:

Secure connection to microsoft.com refused.
Pushing to "simonpj@microsoft.com:/darcs/home/packages/base"...
darcs.exe: bug in darcs!
fromJust error at Push.lhs:136 compiled 11:51:58 Jun 16 2006
Please report this to bugs@darcs.net,
If possible include the output of 'darcs --exact-version'.

I got the host address wrong.  It should be darcs.haskell.org, not Microsoft.com.

But the error message is rather misleading, isn't it?  It says that darcs is at fault.   But it isn't!

Simon
msg1265 (view) Author: kowey Date: 2006-11-24.12:07:31
Yet another example of poor error handling in darcs.  I guess you could say it's
 a bug, in the sense that something goes wrong with ssh and darcs doesn't know
about it.  We ought to fix this too.
msg1283 (view) Author: droundy Date: 2006-11-28.02:49:03
On Fri, Nov 24, 2006 at 10:16:25AM +0000, simonpj wrote:
> I set my defaultrepo file to
>         simonpj@microsoft.com:/home/darcs/packages/base
> and tried to push.  Here's what Darcs said:
> 
> Secure connection to microsoft.com refused.
> Pushing to "simonpj@microsoft.com:/darcs/home/packages/base"...
> darcs.exe: bug in darcs!
> fromJust error at Push.lhs:136 compiled 11:51:58 Jun 16 2006
> Please report this to bugs@darcs.net,
> If possible include the output of 'darcs --exact-version'.
> 
> I got the host address wrong.  It should be darcs.haskell.org, not
> Microsoft.com.
> 
> But the error message is rather misleading, isn't it?  It says that darcs
> is at fault.  But it isn't!

Indeed, this is a bug, which'll take more than the few minutes I've got
free to fix.  We're somehow not realizing that this isn't a valid
repository, which is very bad, and not failing until we are unable to
download a patch.  There should have been a failure in identifyRepository
way back in line 121 of Push.lhs.  So that's where to start looking at
this.  And this looks like a bug that could bite other bits of darcs as
well, so it's very much worth fixing.

I'm cc'ing darcs-devel in hopes of motivating some up-and-coming darcs
developer... or perhaps some overburdened darcs maintainer, but preferably
the former.  I think this is a tractable bug for someone moderately
familiar with Haskell, provided it can be reproduced...

I see that I'm not able to reproduce it! So maybe this is a tricky bug of
some sort.  I hate windows-specific bugs--not that this is necesarily one,
but odds are good, since it doesn't occur on my computer.  :(
-- 
David Roundy
Department of Physics
Oregon State University
msg1348 (view) Author: jch Date: 2006-12-18.00:52:04
I cannot reproduce this bug under Unix.  I suspect that I fixed it on
26 March 2006.  Please reopen it if you can reproduce it with a recent
Darcs.

I've tried various variants of your mistake (unknown hosts, hosts with no
ssh server, hosts with no darcs, incorrect path of the remote repository), and
in all cases I got some variant of the following error:

  darcs failed:  Not a repository: lanthane:/tmp/foo/bar/ (user error ((scp)
failed to fetch: lanthane:/tmp/foo/bar/_darcs/hashed_inventory))

The only part that's confusing is the ``user error'', but that's a bug in the
GHC libraries, not a bug in Darcs.

                                                   Juliusz
msg1350 (view) Author: droundy Date: 2006-12-18.02:08:00
On Mon, Dec 18, 2006 at 12:52:11AM +0000, Juliusz Chroboczek wrote:
> I've tried various variants of your mistake (unknown hosts, hosts with no
> ssh server, hosts with no darcs, incorrect path of the remote repository), and
> in all cases I got some variant of the following error:
> 
>   darcs failed:  Not a repository: lanthane:/tmp/foo/bar/ (user error ((scp)
> failed to fetch: lanthane:/tmp/foo/bar/_darcs/hashed_inventory))
> 
> The only part that's confusing is the ``user error'', but that's a bug in the
> GHC libraries, not a bug in Darcs.

I'd say that it's a bug to reveal the "user error" to our users.  We ought
not to use the show instance on exceptions without first checking whether
they are "user errors".
-- 
David Roundy
http://www.darcs.net
msg1352 (view) Author: jch Date: 2006-12-18.02:53:05
>> The only part that's confusing is the ``user error'', but that's a bug in the
>> GHC libraries, not a bug in Darcs.

> I'd say that it's a bug to reveal the "user error" to our users.  We ought
> not to use the show instance on exceptions without first checking whether
> they are "user errors".

You're right.  Sending a patch straight away.

Sorry for the slander,

                                        Juliusz
History
Date User Action Args
2006-11-24 10:16:24simonpjcreate
2006-11-24 12:07:36koweysetstatus: unread -> unknown
nosy: droundy, tommy, kowey, simonpj
messages: + msg1265
title: Misleading error -> fromJust error at Push.lhs:136, on wrong ssh path during push
2006-11-28 02:49:16droundysetnosy: droundy, tommy, kowey, simonpj
messages: + msg1283
title: fromJust error at Push.lhs:136, on wrong ssh path during push -> Misleading error
2006-12-18 00:52:11jchsetstatus: unknown -> resolved
nosy: + jch
messages: + msg1348
2006-12-18 02:08:01droundysetstatus: resolved -> unknown
nosy: droundy, jch, tommy, kowey, simonpj
messages: + msg1350
2006-12-18 02:53:06jchsetnosy: droundy, jch, tommy, kowey, simonpj
messages: + msg1352
2006-12-18 21:32:21jchsetstatus: unknown -> resolved
nosy: droundy, jch, tommy, kowey, simonpj
2009-08-06 17:32:32adminsetnosy: + markstos, jast, Serware, dmitry.kurochkin, darcs-devel, zooko, dagit, mornfall, simon, beschmi, thorkilnaur, - droundy, jch, simonpj
2009-08-06 20:52:56adminsetnosy: - beschmi
2009-08-10 21:59:13adminsetnosy: + jch, simonpj, - markstos, darcs-devel, zooko, jast, dagit, Serware, mornfall
2009-08-25 17:47:18adminsetnosy: + darcs-devel, - simon
2009-08-27 13:48:22adminsetnosy: jch, tommy, kowey, darcs-devel, simonpj, thorkilnaur, dmitry.kurochkin